fix(textarea): remove autocomplete prop

ionic-team · Aug 19, 2018 · 5989f15 · 5989f15
1 parent ed5c8eb
commit 5989f15
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 15 deletions.
diff --git a/core/src/components.d.ts b/core/src/components.d.ts
@@ -2431,10 +2431,6 @@ declare global {
        * Indicates whether and how the text value should be automatically capitalized as it is entered/edited by the user. Defaults to `"none"`.
        */
       'autocapitalize': string;
-      /**
-       * Indicates whether the value of the control can be automatically completed by the browser. Defaults to `"off"`.
-       */
-      'autocomplete': string;
       /**
        * This Boolean attribute lets you specify that a form control should have input focus when the page loads. Defaults to `false`.
        */
@@ -5977,10 +5973,6 @@ declare global {
        * Indicates whether and how the text value should be automatically capitalized as it is entered/edited by the user. Defaults to `"none"`.
        */
       'autocapitalize'?: string;
-      /**
-       * Indicates whether the value of the control can be automatically completed by the browser. Defaults to `"off"`.
-       */
-      'autocomplete'?: string;
       /**
        * This Boolean attribute lets you specify that a form control should have input focus when the page loads. Defaults to `false`.
        */

diff --git a/core/src/components/col/readme.md b/core/src/components/col/readme.md
@@ -64,6 +64,7 @@ There are several attributes that can be added to a column to customize this beh
 | `--ion-grid-column-padding-sm` | Padding for the Column on sm screens and up |
 | `--ion-grid-column-padding-xl` | Padding for the Column on xl screens and up |
 | `--ion-grid-column-padding-xs` | Padding for the Column on xs screens and up |
+| `--ion-grid-columns`           | The number of total Columns in the Grid     |
 
 
 ----------------------------------------------

diff --git a/core/src/components/textarea/readme.md b/core/src/components/textarea/readme.md
@@ -16,7 +16,6 @@ The textarea component accepts the [native textarea attributes](https://develope
 | Property         | Attribute        | Description                                                                                                                                                                                                                                                            | Type      |
 | ---------------- | ---------------- | ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | --------- |
 | `autocapitalize` | `autocapitalize` | Indicates whether and how the text value should be automatically capitalized as it is entered/edited by the user. Defaults to `"none"`.                                                                                                                                | `string`  |
-| `autocomplete`   | `autocomplete`   | Indicates whether the value of the control can be automatically completed by the browser. Defaults to `"off"`.                                                                                                                                                         | `string`  |
 | `autofocus`      | `autofocus`      | This Boolean attribute lets you specify that a form control should have input focus when the page loads. Defaults to `false`.                                                                                                                                          | `boolean` |
 | `clearOnEdit`    | `clear-on-edit`  | If true, the value will be cleared after focus upon edit. Defaults to `true` when `type` is `"password"`, `false` for all other types.                                                                                                                                 | `boolean` |
 | `color`          | `color`          | The color to use from your application's color palette. Default options are: `"primary"`, `"secondary"`, `"tertiary"`, `"success"`, `"warning"`, `"danger"`, `"light"`, `"medium"`, and `"dark"`. For more information on colors, see [theming](/docs/theming/basics). | `Color`   |

diff --git a/core/src/components/textarea/textarea.tsx b/core/src/components/textarea/textarea.tsx
@@ -67,11 +67,6 @@ export class Textarea implements TextareaComponent {
    */
   @Prop() autocapitalize = 'none';
 
-  /**
-   * Indicates whether the value of the control can be automatically completed by the browser. Defaults to `"off"`.
-   */
-  @Prop() autocomplete = 'off';
-
   /**
    * This Boolean attribute lets you specify that a form control should have input focus when the page loads. Defaults to `false`.
    */
@@ -256,7 +251,6 @@ export class Textarea implements TextareaComponent {
         class="native-textarea"
         ref={el => this.inputEl = el as HTMLTextAreaElement}
         autoCapitalize={this.autocapitalize}
-        // autoComplete={this.autocomplete}
         autoFocus={this.autofocus}
         disabled={this.disabled}
         maxLength={this.maxlength}