fix(scroll): memory leak on document event listener

resetScrollView event listener is added on document but it is never removed closes #4746
ionic-team · Jul 14, 2016 · 491e256 · 491e256
1 parent 5fdb110
commit 491e256
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/js/views/scrollViewNative.js b/js/views/scrollViewNative.js
@@ -554,15 +554,14 @@
       var self = this;
       var container = self.__container;
 
-      container.removeEventListener('resetScrollView', self.resetScrollView);
       container.removeEventListener('scroll', self.onScroll);
-
       container.removeEventListener('scrollChildIntoView', self.scrollChildIntoView);
-      container.removeEventListener('resetScrollView', self.resetScrollView);
 
       container.removeEventListener(ionic.EVENTS.touchstart, self.handleTouchMove);
       container.removeEventListener(ionic.EVENTS.touchmove, self.handleTouchMove);
 
+      document.removeEventListener('resetScrollView', self.resetScrollView);
+
       ionic.tap.removeClonedInputs(container, self);
 
       delete self.__container;