fix(picker): fix iOS picker options that shouldn't be showing (#16055)

ionic-team · Oct 24, 2018 · 02ef52b · 02ef52b
1 parent b2021fd
commit 02ef52b
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 0 deletions.
diff --git a/core/src/components/datetime/test/standalone/e2e.ts b/core/src/components/datetime/test/standalone/e2e.ts
@@ -13,6 +13,7 @@ it('datetime: standalone', async () => {
 
   const picker = await page.find('ion-picker');
   await picker.waitForVisible();
+  await page.waitFor(250);
 
   compare = await page.compareScreenshot('should open basic picker');
   expect(compare).toMatchScreenshot();

diff --git a/core/src/components/picker-column/picker-column.tsx b/core/src/components/picker-column/picker-column.tsx
@@ -116,7 +116,10 @@ export class PickerColumnCmp implements ComponentInterface {
           translateY = 0;
           translateZ = 90;
           transform = `rotateX(${rotateX}deg) `;
+        } else {
+          translateY = -9999;
         }
+
       } else {
         translateZ = 0;
         translateY = optOffset;

diff --git a/core/src/components/select/test/basic/e2e.ts b/core/src/components/select/test/basic/e2e.ts
@@ -13,6 +13,7 @@ it('select: basic', async () => {
 
   const alert = await page.find('ion-alert');
   await alert.waitForVisible();
+  await page.waitFor(100);
 
   compare = await page.compareScreenshot('should open gender single select');
   expect(compare).toMatchScreenshot();
@@ -21,6 +22,7 @@ it('select: basic', async () => {
 
   select = await page.find('#customSelect');
   await select.click();
+  await page.waitFor(100);
 
   const actionSheet = await page.find('ion-action-sheet');
   await actionSheet.waitForVisible();