Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(popover): position properly in RTL / MD modes #16745

Merged
merged 7 commits into from
Jan 9, 2019

Conversation

abennouna
Copy link
Contributor

Short description of what this resolves:

In MD / RTL mode, popovers are not positioned properly.

Changes proposed in this pull request:

  • If the directionality is RTL, calculate the correct left position

TODO: update the animation “direction” as well. This should be done by having the transform-origin relative to the right (start) in RTL.

Ionic Version: 4.0.0-beta.18

Fixes: #15662

abennouna and others added 2 commits December 14, 2018 15:43
chore(): update to latest master
TODO: animation should also be updated for RTL mode
@ionitron-bot ionitron-bot bot added the package: core @ionic/core package label Dec 14, 2018
@abennouna abennouna changed the title fix(popover): position properly in RTL / MD modesr fix(popover): position properly in RTL / MD modes Dec 14, 2018
@mohamedsharaf
Copy link

merge please :)

@adamdbradley adamdbradley merged commit 7846019 into ionic-team:master Jan 9, 2019
@abennouna abennouna deleted the fix-rtl-popover branch January 9, 2019 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants