Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Empty area when "spinner='none'" for ion-refresher #3372

Closed
sikron opened this issue Mar 22, 2015 · 7 comments
Closed

bug: Empty area when "spinner='none'" for ion-refresher #3372

sikron opened this issue Mar 22, 2015 · 7 comments
Assignees

Comments

@sikron
Copy link

sikron commented Mar 22, 2015

Type: bug

Platform: all

Hi,
i am implementing my own loading overlay, so i want no spinner displayed at all for pull-to-refresh. When i now use "spinner='none'" as attribute of the ion-refresher, no spinner is displayed (good), but the area where the spinner used to be is still there as empty area (bad), as long as the refreshing takes.
In my opinion, for "spinner='none'", also the area should not be displayed.

Maybe related to #2926

@sikron sikron changed the title Empty area when "spinner='none'" for ion-refresher bug: Empty area when "spinner='none'" for ion-refresher Mar 22, 2015
@perrygovier perrygovier self-assigned this Mar 24, 2015
@perrygovier
Copy link
Contributor

Well, the wrapping element needs to exist to contain the pulling icons, but are you saying it shouldn't pause at 50 or so px until the complete event fires?

@perrygovier perrygovier added the needs: reply the issue needs a response from the user label Mar 24, 2015
@sikron
Copy link
Author

sikron commented Mar 24, 2015

Hi, thx for answering!
You are right. I made a picture, though, to be absolutely clear:
The green arrow points to my loading animation (because of which i don't want the pull-to-refresh spinner). The read rectangle is, where the empty spinner area is. After pulling, the area stays until the 'scroll.refreshComplete' event is broadcasted. Afterwards it goes aways and my content begins at the very top of the page.
empty-spinner-area

@Ionitron Ionitron removed the needs: reply the issue needs a response from the user label Mar 24, 2015
@khfayzullaev
Copy link

@sikron, thanks for pointing out this issue. I have the same problem. Moreover, @perrygovier, this issue is also related to this category of problems.

@grrrian
Copy link

grrrian commented Jul 13, 2015

+1

@jgw96
Copy link
Contributor

jgw96 commented May 17, 2016

Hello all! Is this still an issue with the latest version of ionic? Thanks!

@zookz
Copy link

zookz commented Jun 2, 2016

+1

@jgw96
Copy link
Contributor

jgw96 commented Jun 2, 2016

Hello all! As it seems it has been a while since there was any activity on this issue i will be closing it for now. Feel free to comment if you are still running into this issue. Thanks for using Ionic!

@jgw96 jgw96 closed this as completed Jun 2, 2016
@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants