Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: No Backdrop Shades In Modals Anymore #3067

Closed
vladipus opened this issue Feb 10, 2015 · 3 comments
Closed

bug: No Backdrop Shades In Modals Anymore #3067

vladipus opened this issue Feb 10, 2015 · 3 comments

Comments

@vladipus
Copy link

Type: bug

Platform: all

I can't really understand, why this change was made:
5de1c12

My 1080p device won't show the backdrop, even in a landscape orientation!

@vladipus vladipus changed the title No Backdrop Shades In Modals Anymore bug: No Backdrop Shades In Modals Anymore Feb 10, 2015
@vladipus
Copy link
Author

I now understand why this happened. On small, non-tablet displays the dialog just occupies the whole space. However, I'm more interested in this to work correctly (with the backdrop): http://codepen.io/anandvj/pen/KwmMGY
If you minify the viewport during the image view, the backdrop is just gone.

@vladipus
Copy link
Author

I suggest adding an option to add specific class to the backdrop, something like backdropClass
For now, I'm adding a specific class like this:

$ionicModal.fromTemplateUrl('template.html', {
    scope: $scope,
    animation: 'slide-in-up',
    // I suggest this: backdropClass: 'showcase'
}).then(function(imageModal) {
    $scope.imageModal = imageModal;
    // For now doing this:
    angular.element($scope.imageModal.el).addClass('showcase');
});

@Ionitron
Copy link
Collaborator

Greetings @vladipus!

I've closed this issue because my sensors indicated it was old and inactive, and may have already been fixed in recent versions of Ionic. However, if you are still experiencing this issue, please feel free to reopen this issue by creating a new one, and include any examples and other necessary information, so that we can look into it further.

Thank you for allowing me to assist you.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants