Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Side menus interfer with other elements #2695

Closed
arcanis opened this issue Dec 9, 2014 · 4 comments
Closed

Side menus interfer with other elements #2695

arcanis opened this issue Dec 9, 2014 · 4 comments
Assignees

Comments

@arcanis
Copy link

arcanis commented Dec 9, 2014

Two issues in one (nightly):

  • An horizontal scroll will broke if there is a side menu (it won't be possible to correctly scroll the content)

    Ex: This codepen doesn't work

  • An element with data-prevent-scroll will not cascade the event prevention to its children. It means that in order to work, one has to mark every element with the data-prevent-scroll attribute.

    Ex: This codepen doesn't work, and this one does work.

    A workaround is something like this:

    function controller( $element ) {
        $element.find( '[data-prevent-scroll="true"]' ).find( '*' ).addBack( ).attr( 'data-prevent-scroll', 'true' );
    }
@arcanis
Copy link
Author

arcanis commented Dec 10, 2014

I just noticed that the first bug is related to issues #1418 and #1725, so I'll try to workaround using one of the suggestions that can be found here. However, I think that it would be best to solve it in the framework — for example, could it be possible for the side menus to only catch the drag event if the closest scroll item is already at his max scroll level?

@mlynch
Copy link
Contributor

mlynch commented Dec 12, 2014

Fixed! Give master a try. Thanks.

@arcanis
Copy link
Author

arcanis commented Dec 14, 2014

@mlynch Thanks! And for the second issue? Should I open another thread?

An element with data-prevent-scroll will not cascade the event prevention to its children. It means that in order to work, one has to mark every element with the data-prevent-scroll attribute.

@ionitron-bot
Copy link

ionitron-bot bot commented Sep 6, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants