-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: non-passive event listener for 'touchstart' event #25599
Comments
Hello @aparajita thanks for the issue! Would it be possible to make the reproduction app a public repository? Thanks! |
After some brief discovery, this seems to occur in two areas:
I'll need to consult with the team + the Stencil team with regards to the touch start binding. Currently there isn't a way to register passive event listeners through JSX bindings. This may be a case where we just manually add an event listener. |
Thanks for taking a look! |
@sean-perkins That repo is public, were you not able to access it? |
@aparajita I was not, the link results in a 404. Did you perhaps mean to point to: https://github.com/aparajita/capacitor-biometric-auth-demo? |
Yes, doh! 🫢 |
Hello @aparajita can you try with this dev-build and let me know if you observe any errors/unexpected changes in behavior and if the warnings are resolved?
I did some brief testing in our local reproduction and things appear to be functional. Without problematic behavior outside the warning however, doesn't hurt to have a second set of eyes 👍 Thanks! |
Looks good here, thank you! |
Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out. |
Prerequisites
Ionic Framework Version
Current Behavior
When loading an Ionic/Vue page with verbose logging on in Brave (which is Chromium-based), the following warning appears:
Expected Behavior
No warning should appear.
Steps to Reproduce
git clone https://github.com/aparajita/biometric-auth-demo.git cd biometric-auth-demo pnpm install pnpm dev
Code Reproduction URL
https://github.com/aparajita/capacitor-biometric-auth-demo
Ionic Info
Ionic:
Ionic CLI : 6.20.1 (/Users/aparajita/Library/pnpm/global/5/.pnpm/@Ionic[email protected]/node_modules/@ionic/cli)
Capacitor:
Capacitor CLI : 3.6.0
@capacitor/android : 3.6.0
@capacitor/core : 3.6.0
@capacitor/ios : 3.6.0
Utility:
cordova-res : 0.15.4
native-run : not installed globally
System:
NodeJS : v18.4.0 (/Users/aparajita/.fnm/node-versions/v18.4.0/installation/bin/node)
npm : 8.12.1
OS : macOS Monterey
Additional Information
No response
The text was updated successfully, but these errors were encountered: