Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTL: offset-*, pull-* and push-* not rendering properly #16701

Closed
abennouna opened this issue Dec 12, 2018 · 4 comments
Closed

RTL: offset-*, pull-* and push-* not rendering properly #16701

abennouna opened this issue Dec 12, 2018 · 4 comments
Labels
package: core @ionic/core package type: bug a confirmed bug report

Comments

@abennouna
Copy link
Contributor

Bug Report

Ionic version:
[x] 4.x

Current behavior:
When the document is RTL, the offset-*, push-* and pull-* directives do not render as expected.

Expected behavior:
The offset, pull, and push, should work on RTL.

Steps to reproduce:

  1. Go to the demo;
  2. If your display is already LTR, skip to 4;
  3. Click on the "TOGGLE LTR / RTL" button in order to get a LTR display;
  4. Scroll down a bit to the grids, and observe the correct offsets, pulls, and pushs;
  5. Click on the "TOGGLE LTR / RTL" button in order to get an RTL display;
  6. Notice the incorrect offsets, pulls, and pushs.

Related code:

Other information:
Currently, the Col component hard-codes the margin-left, left, and right CSS properties.

I'm creating a PR for this.

Ionic info:

Ionic:

   ionic (Ionic CLI)             : 4.5.0 (~/.nvm/versions/node/v10.12.0/lib/node_modules/ionic)
   Ionic Framework               : @ionic/angular 4.0.0-beta.17
   @angular-devkit/build-angular : 0.10.7
   @angular-devkit/schematics    : 7.0.7
   @angular/cli                  : 7.0.7
   @ionic/angular-toolkit        : 1.2.0

System:

   NodeJS : v10.12.0 (~/.nvm/versions/node/v10.12.0/bin/node)
   npm    : 6.4.1
   OS     : macOS High Sierra
@brandyscarney
Copy link
Member

Thank you for the PR! We will review this.

@mohamedsharaf
Copy link

hope this was fixed b4 the release 0 @brandyscarney

@abennouna
Copy link
Contributor Author

Closed in favor of #17012

@ionitron-bot
Copy link

ionitron-bot bot commented Feb 8, 2019

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Feb 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
package: core @ionic/core package type: bug a confirmed bug report
Projects
None yet
Development

No branches or pull requests

3 participants