Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default values in documentation #1404

Closed
mrzmyr opened this issue May 15, 2014 · 5 comments
Closed

Default values in documentation #1404

mrzmyr opened this issue May 15, 2014 · 5 comments

Comments

@mrzmyr
Copy link

mrzmyr commented May 15, 2014

Hey there, i was missing default values in the documentation at the $ionicLoading Service.

  1. Is it planned to provide those (and should I create a PR for it)?
  2. Are there any plans to get a link to the source in the documentation (as known from the angular documentation) ?
@adamdbradley
Copy link
Contributor

Yes a PR would be welcomed.

I'm not sure I follow on what you mean with "as known from the angular documentation".

@mrzmyr
Copy link
Author

mrzmyr commented May 18, 2014

I mean the button "view source", which open up source file itself:
bildschirmfoto 2014-05-19 um 00 47 34

@ajoslin
Copy link
Contributor

ajoslin commented Jun 6, 2014

'Improve this doc' already goes to the source.

@ajoslin ajoslin closed this as completed in dfdf084 Jun 6, 2014
@ajoslin
Copy link
Contributor

ajoslin commented Jun 6, 2014

Added a 'View Source' link, that doesn't go into editing the doc.

you can view it in the nightly docs and it will start being in next release.

@ionitron-bot
Copy link

ionitron-bot bot commented Sep 6, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants