Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collection Repeat + Infinite Scroll #1380

Closed
perrygovier opened this issue May 13, 2014 · 20 comments
Closed

Collection Repeat + Infinite Scroll #1380

perrygovier opened this issue May 13, 2014 · 20 comments
Milestone

Comments

@perrygovier
Copy link
Contributor

It appears that the spinner is hidden at the top of the page rather than at the bottom of the list when using infinite scroll with a collection repeat. We should modify the collection-repeat logic to consider siblings in its scrolling calculations.

@epelc
Copy link

epelc commented Jun 22, 2014

I'm also having this problem with infinite scroll and collection repeat. Also I don't think the scroll icon showing above the collection repeat is specific to infinite scroll because you also get the same problem with a ion-item under the collection repeat.

@epelc
Copy link

epelc commented Jun 22, 2014

Just to confirm if i change back to ng-repeat it works perfectly fine so this is probably just an issue with how collection-repeat shows at the bottom of an ion-list

@anilsharma85175
Copy link

When is the fix coming? Without this fix you really can not use collection repeat directive. Infinite scroll comes naturally with collection repeat

@ajoslin
Copy link
Contributor

ajoslin commented Jul 10, 2014

This definitely does need to be fixed, I'll look at it within the week.

@zelphir
Copy link

zelphir commented Jul 21, 2014

@ajoslin Hi, any news? 😄

@ajoslin
Copy link
Contributor

ajoslin commented Aug 6, 2014

Fixed. collection-repeat now fits in with any other elements that are inside the ion-content.

@zelphir
Copy link

zelphir commented Aug 7, 2014

@ajoslin With the latest update collection-repeat and infinite-scroll don't work anymore. The on-infinite function is called several times (that means the all the collection-repeat items are duplicated). Had to switch back to beta.10

@epelc
Copy link

epelc commented Sep 24, 2014

@zelphir What version did it not work on? Have you tried it with beta 12? Just asking before I go and try to get it working again in my project.

@VladimirPal
Copy link

Works for me with beta 12.

@naavis
Copy link

naavis commented Nov 14, 2014

I'm still experiencing the hidden spinner icon, even with beta 13. There also seems to be another report on this: #2376

@epelc
Copy link

epelc commented Nov 14, 2014

@naavis I also still have the same problem with beta-13

@malikov
Copy link

malikov commented Nov 19, 2014

I'm using beta-13 and have the same issue :(

@JonathanWi
Copy link

Same issue here on beta-14

@pulakb
Copy link

pulakb commented Jan 5, 2015

Collection Repeat + Infinite Scroll is working for me in beta 13 but it is not working in beta 14. Why is this so @ajoslin @adamdbradley?

@vishnukhaunte
Copy link

Any update on this issue? Since its very urgent. Thanx

@Set2005
Copy link

Set2005 commented Jan 19, 2015

beta14 doesn't work, any hotfi?

@JWesorick
Copy link

+1

@agianikas
Copy link

+1

@Screeze
Copy link

Screeze commented Dec 20, 2015

Just tried 1.2, and for me its still not working. When loading the page, it fires loading once, and never again.

    <ion-list>
        <a class="my-item"
           collection-repeat="x in y"
           collection-item-height="240px"
           collection-item-width="200px"
           ng-href="xxx">
            <div class="card">
                <img ng-src="{{x.b}}" width="100%"><br>
                <span>
                    {{x.a}} ({{x.b}})
                </span>
            </div>
        </a>
    </ion-list>
    <ion-infinite-scroll
            icon="ion-loading-c"
            on-infinite="loadMore()"
            distance="500px">
    </ion-infinite-scroll>

Also tried distance="20%" and other values.

@michel-eu
Copy link

Hey @Screeze, i've faced the same problem in 1.1.

What happend is @ajoslin fixed this issue adding a display:block in the element after collection-repeat (infinte-scroll, in this case), here is the link #2376 (comment).

And i'd changed the css (for layout purposes) like this:

.collection-repeat-after-container {
    display: inline!important;
}

I've just removed this css and the infinite-scroll worked fine in collection repeat.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests