feat(ios): Add new iOS15 media capture permission delegate #5196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samydoesit
force-pushed
the
ios15_new_permission_delegate
branch
from
3d43b44 to
195a1b5
Compare
|
Looks like that the CI should use latest Xcode13 on macos-11. actions/runner-images#4060 |
jcesarmobile
requested changes
Nov 22, 2021
There was a problem hiding this comment.
Hello.
Thanks for the PR!
Since we still need to support Xcode 12 and the method is not available there, the function needs to be wrapped inside a #if compiler(>=5.5) as proposed since that's the swift version shipped on Xcode 13, so that code won't run on Xcode 12 but the build won't fail as it does now.
Co-authored-by: jcesarmobile <[email protected]>
Co-authored-by: jcesarmobile <[email protected]>
jcesarmobile
approved these changes
Nov 22, 2021
samgabriel
added a commit
to Brainfuse/cordova-plugin-ionic-webview
that referenced
this pull request
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delegates media capture permissions to the app and remembers the user's decision for iOS15.
https://developer.apple.com/documentation/webkit/wkuidelegate/3763087-webview#discussion
Thanks and credits to @7freaks-otte who found the solution. :)
https://forum.ionicframework.com/t/prevent-for-reprompting-webrtc-webview-permissions-ios15/215240/2?u=samydoesit
You can test these changes using my getusermedia demo case when build on Xcode13 -> https://github.com/samydoesit/capacitor-getusermedia-test