Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(messaging, types): export correct module types #8336

Merged
merged 1 commit into from
Feb 15, 2025

Conversation

radko93
Copy link
Contributor

@radko93 radko93 commented Feb 15, 2025

Description

Wrong type for messaging module in the modular types.

Related issues

Release Summary

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan

Import the getMessaging function.

Think react-native-firebase is great? Please consider supporting the project with any of the below:

Copy link

vercel bot commented Feb 15, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 15, 2025 8:14am

Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦 good catch, apologies
going to do a release shortly with the various type fixes we have queued up already

@mikehardy mikehardy changed the title fix: messaging modular types fix(messaging, types): export correct module types Feb 15, 2025
@mikehardy mikehardy merged commit b39f5a4 into invertase:main Feb 15, 2025
16 of 18 checks passed
@radko93 radko93 deleted the patch-1 branch February 16, 2025 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants