Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(expo, ios): expo plugin added import multiple times #6507

Conversation

DoctorJohn
Copy link
Contributor

Description

This PR fixes a regression introduced in #6223 and reported in #6477.

Related issues

Fixes #6477

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan

I added a test that fails without the changes and succeeds with them :)


Think react-native-firebase is great? Please consider supporting the project with any of the below:

@vercel
Copy link

vercel bot commented Sep 3, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-native-firebase ✅ Ready (Inspect) Visit Preview Sep 3, 2022 at 4:03PM (UTC)
1 Ignored Deployment
Name Status Preview Updated
react-native-firebase-next ⬜️ Ignored (Inspect) Sep 3, 2022 at 4:03PM (UTC)

@DoctorJohn DoctorJohn force-pushed the fix-expo-plugin-added-firebase-import-multiple-times branch from c55c64d to d58fce2 Compare September 3, 2022 15:55
@codecov
Copy link

codecov bot commented Sep 3, 2022

Codecov Report

Merging #6507 (9a3a897) into main (a05f63d) will increase coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head 9a3a897 differs from pull request most recent head d58fce2. Consider uploading reports for the commit d58fce2 to get more accurate results

@@            Coverage Diff             @@
##             main    #6507      +/-   ##
==========================================
+ Coverage   72.30%   72.33%   +0.03%     
==========================================
  Files         109      109              
  Lines        4657     4657              
  Branches     1048     1048              
==========================================
+ Hits         3367     3368       +1     
+ Misses       1212     1211       -1     
  Partials       78       78              

Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, and a test! Bestill my heart ❤️ 😆
Thank you @DoctorJohn

@mikehardy mikehardy added the Workflow: Pending Merge Waiting on CI or similar label Sep 3, 2022
@mikehardy mikehardy merged commit f10891a into invertase:main Sep 4, 2022
@mikehardy mikehardy removed the Workflow: Pending Merge Waiting on CI or similar label Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expo app plugin adds Firebase import multiple times [Expo 45]
2 participants