fix(messaging): Fixes a race condition between `FIRAuth/didReceiveRem… #6392

glesperance · 2022-07-15T22:22:07Z

Description

Fixes a race condition between FIRAuth/didReceiveRemoteNotification and the RNFB/messaging module causing detox to hang when FIRAuth/didReceiveRemoteNotification is called first.

This problem is caused by a bug in the @react-native-firebase/messaging implementation of application: didReceiveRemoteNotification: fetchCompletionHandler: (in @react-native-firebase/messaging/ios/RNFBMessaging/RNFBMessaging+AppDelegate.m).

The implementation gets into a race with FIRAuth/didReceiveRemoteNotification which causes react-native-firebase/messaging to not callback the completion handler if FIRAuth's function ran first.

This in turns causes detox to randomly (and often) hang with the following error:

detox[41991] INFO:  [APP_STATUS] The app is busy with the following tasks:
• There are 2 work items pending on the dispatch queue: "Main Queue (<OS_dispatch_queue_main: com.apple.main-thread>)".
• Run loop "Main Run Loop" is awake.

Related issues

Release Summary

The patch fixes a race condition between FIRAuth/didReceiveRemoteNotification and the RNFB/messaging module causing detox to hang when FIRAuth/didReceiveRemoteNotification is called first.

Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
- Yes
My change supports the following platforms;
- Android
- iOS
My change includes tests;
- e2e tests added or updated in packages/\*\*/e2e
- jest tests added or updated in packages/\*\*/__tests__
I have updated TypeScript types that are affected by my change.
This is a breaking change;
- Yes
- No

Test Plan

This is another tale from the deep-internals of Detox / RNFB / Firebase sdks playing not so well together -- and making tests extremely flaky. It will be hard to make a test harness for this.

However...

Unit tests are passing (with the exception of two tests that had to be skipped bc they had team/env specific values that made them fail):

gabriel@mt react-native-firebase % yarn tests:jest --silent
yarn run v1.22.18
$ jest --silent
 PASS  packages/app/plugin/__tests__/androidPlugin.test.ts (12.67 s)
 PASS  packages/app-distribution/__tests__/app-distribution.test.ts (12.741 s)
 PASS  packages/crashlytics/plugin/__tests__/androidPlugin.test.ts (12.73 s)
 PASS  packages/perf/plugin/__tests__/androidPlugin.test.ts (12.758 s)
 PASS  packages/app/plugin/__tests__/iosPlugin.test.ts (12.799 s)
 PASS  packages/app-check/__tests__/appcheck.test.ts (12.843 s)
 PASS  packages/perf/__tests__/perf.test.ts (12.883 s)
 PASS  packages/functions/__tests__/functions.test.ts (12.89 s)
 PASS  packages/remote-config/__tests__/remote-config.test.ts (12.892 s)
 PASS  packages/installations/__tests__/installations.test.ts (12.881 s)
 PASS  packages/database/__tests__/database.test.ts (12.905 s)
 PASS  packages/firestore/__tests__/firestore.test.ts (12.949 s)
 PASS  packages/auth/__tests__/auth.test.ts (12.968 s)
 PASS  packages/storage/__tests__/storage.test.ts (12.982 s)
 PASS  packages/analytics/__tests__/analytics.test.ts (13.068 s)
 PASS  packages/crashlytics/__tests__/crashlytics.test.ts

Test Suites: 16 passed, 16 total
Tests:       1 skipped, 158 passed, 159 total
Snapshots:   11 passed, 11 total
Time:        14.182 s, estimated 22 s
✨  Done in 14.89s.
gabriel@mt react-native-firebase %

As well as e2e tests:

gabriel@mt react-native-firebase % yarn tests:ios:test
yarn run v1.22.18
$ cd tests && SIMCTL_CHILD_GULGeneratedClassDisposeDisabled=1 SIMCTL_CHILD_FIRAAppCheckDebugToken=698956B2-187B-49C6-9E25-C3F3530EEBAF yarn detox test --configuration ios.sim.debug --loglevel warn
$ /Users/gabriel/Workspace/paltap-io/react-native-firebase/tests/node_modules/.bin/detox test --configuration ios.sim.debug --loglevel warn


Running application testing ({
    initialProps =     {
        isHeadless = 0;
    };
    rootTag = 11;
})
  App -> NativeModules -> Constants
    .apps
      ✔ should be an array
      ✔ array items contain name, options & state properties

  firebase
    ✔ it should allow read the default app from native
    ✔ it should create js apps for natively initialized apps
    ✔ natively initialized apps should have options available in js
    ✔ SDK_VERSION should return a string version
    ✔ apps should provide an array of apps
    ✔ apps can get and set data collection
    ✔ should allow setting of log level
    ✔ should error if logLevel is invalid
    ✔ it should initialize dynamic apps
    ✔ should error if dynamic app initialization values are incorrect
    ✔ should error if dynamic app initialization values are invalid
    ✔ apps can be deleted, but only once
    ✔ prevents the default app from being deleted
    ✔ extendApp should provide additional functionality

 [...]

  auth()
    namespace
      ✔ accessible from firebase.app()
      ✔ supports multiple apps
    applyActionCode()
      - works as expected
      ✔ errors on invalid code
    checkActionCode()
      ✔ errors on invalid code
    reload()
      ✔ Meta data returns as expected with annonymous sign in
      ✔ Meta data returns as expected with email and password sign in
    confirmPasswordReset()
      ✔ errors on invalid code via API
    signInWithCustomToken()
      - signs in with a admin sdk created custom auth token
    onAuthStateChanged()
      ✔ calls callback with the current user and when auth state changes
      ✔ accept observer instead callback as well
      ✔ stops listening when unsubscribed
      ✔ returns the same user with multiple subscribers #1815
    onIdTokenChanged()
      ✔ calls callback with the current user and when auth state changes
      ✔ stops listening when unsubscribed
      ✔ listens to a null user when auth result is not defined
    onUserChanged()
      ✔ calls callback with the current user and when auth state changes
      ✔ stops listening when unsubscribed
    signInAnonymously()
      ✔ it should sign in anonymously
    signInWithEmailAndPassword()
      ✔ it should login with email and password
      ✔ it should error on login if user is disabled
      ✔ it should error on login if password incorrect
      ✔ it should error on login if user not found
    signInWithCredential()
      ✔ it should login with email and password
      ✔ it should error on login if user is disabled
      ✔ it should error on login if password incorrect
      ✔ it should error on login if user not found
    createUserWithEmailAndPassword()
      ✔ it should create a user with an email and password
      ✔ it should error on create with invalid email
      ✔ it should error on create if email in use
      ✔ it should error on create if password weak
    fetchSignInMethodsForEmail()
      ✔ it should return password provider for an email address
      ✔ it should return an empty array for a not found email
      ✔ it should return an error for a bad email address
    signOut()
      ✔ it should reject signOut if no currentUser
    delete()
      ✔ should delete a user
    languageCode
      ✔ it should change the language code
    getRedirectResult()
      ✔ should throw an unsupported error
    setPersistence()
      ✔ should throw an unsupported error
    signInWithPopup
      ✔ should throw an unsupported error
    sendPasswordResetEmail()
      ✔ should not error
      ✔ should verify with valid code
      ✔ should fail to verify with invalid code
      ✔ should change password correctly OOB
      ✔ should change password correctly via API
    signInWithRedirect()
      ✔ should throw an unsupported error
    useDeviceLanguage()
      ✔ should throw an unsupported error
    useUserAccessGroup()
      - should return "null" when accessing a group that exists
      - should throw when requesting an inaccessible group
    setTenantId()
      ✔ should return null if tenantId unset

  auth() -> emailLink Provider
    sendSignInLinkToEmail
      ✔ should send email
      ✔ sign in via email works
      - should send email with defaults
    isSignInWithEmailLink
      ✔ should return true/false
    signInWithEmailLink
      - should signIn

  auth() => Phone
    signInWithPhoneNumber
      ✔ signs in with a valid code
      ✔ errors on invalid code
    verifyPhoneNumber
      ✔ successfully verifies
      ✔ uses the autoVerifyTimeout when a non boolean autoVerifyTimeoutOrForceResend is provided
      ✔ throws an error with an invalid on event
      ✔ throws an error with an invalid observer event
      ✔ successfully runs verification complete handler
      ✔ successfully runs and calls success callback
      - successfully runs and calls error callback
      ✔ catches an error and emits an error event

  auth() -> Providers
    EmailAuthProvider
      constructor
        ✔ should throw an unsupported error
      credential
        ✔ should return a credential object
      credentialWithLink
        ✔ should return a credential object
      EMAIL_PASSWORD_SIGN_IN_METHOD
        ✔ should return password
      EMAIL_LINK_SIGN_IN_METHOD
        ✔ should return emailLink
      PROVIDER_ID
        ✔ should return password
    FacebookAuthProvider
      constructor
        ✔ should throw an unsupported error
      credential
        ✔ should return a credential object
      credentialLimitedLogin
        ✔ should return a credential object
      PROVIDER_ID
        ✔ should return facebook.com
    GithubAuthProvider
      constructor
        ✔ should throw an unsupported error
      credential
        ✔ should return a credential object
      PROVIDER_ID
        ✔ should return github.com
    GoogleAuthProvider
      constructor
        ✔ should throw an unsupported error
      credential
        ✔ should return a credential object
      PROVIDER_ID
        ✔ should return google.com
    OAuthProvider
      constructor
        ✔ should throw an unsupported error
      credential
        ✔ should return a credential object
      PROVIDER_ID
        ✔ should return oauth
    PhoneAuthProvider
      constructor
        ✔ should throw an unsupported error
      credential
        ✔ should return a credential object
      PROVIDER_ID
        ✔ should return phone
    TwitterAuthProvider
      constructor
        ✔ should throw an unsupported error
      credential
        ✔ should return a credential object
      PROVIDER_ID
        ✔ should return twitter.com

  auth()
    firebase.auth().currentUser
      - exists after reload

  auth().currentUser
    getIdToken()
      ✔ should return a token
    getIdTokenResult()
      ✔ should return a valid IdTokenResult Object
    linkWithCredential()
      ✔ should link anonymous account <-> email account
      ✔ should error on link anon <-> email if email already exists
    reauthenticateWithCredential()
      ✔ should reauthenticate correctly
    reload()
      ✔ should not error
    sendEmailVerification()
      ✔ should error if actionCodeSettings.url is not present
      ✔ should error if actionCodeSettings.url is not a string
      ✔ should error if actionCodeSettings.dynamicLinkDomain is not a string
      ✔ should error if handleCodeInApp is not a string
      ✔ should error if actionCodeSettings.iOS is not an object
      ✔ should error if actionCodeSettings.iOS.bundleId is not a string
      ✔ should error if actionCodeSettings.android is not an object
      ✔ should error if actionCodeSettings.android.packageName is not a string
      ✔ should error if actionCodeSettings.android.installApp is not a string
      ✔ should error if actionCodeSettings.android.minimumVersion is not a string
      ✔ should not error
      ✔ should correctly report emailVerified status
      ✔ should work with actionCodeSettings
      ✔ should throw an error within an invalid action code url
    verifyBeforeUpdateEmail()
      ✔ should error if newEmail is not a string
      ✔ should error if actionCodeSettings.url is not present
      ✔ should error if actionCodeSettings.url is not a string
      ✔ should error if actionCodeSettings.dynamicLinkDomain is not a string
      ✔ should error if handleCodeInApp is not a boolean
      ✔ should error if actionCodeSettings.iOS is not an object
      ✔ should error if actionCodeSettings.iOS.bundleId is not a string
      ✔ should error if actionCodeSettings.android is not an object
      ✔ should error if actionCodeSettings.android.packageName is not a string
      ✔ should error if actionCodeSettings.android.installApp is not a boolean
      ✔ should error if actionCodeSettings.android.minimumVersion is not a string
      - should not error
      - should work with actionCodeSettings
    unlink()
      ✔ should unlink the email address
    updateEmail()
      ✔ should update the email address
    updatePhoneNumber()
      ✔ should update the phone number
    updatePassword()
      ✔ should update the password
      - should throw too many requests when limit has been reached
    updateProfile()
      ✔ should update the profile
      ✔ should return a valid profile when signing in anonymously
    linkWithPhoneNumber()
      ✔ should throw an unsupported error
    linkWithPopup()
      ✔ should throw an unsupported error
    linkWithRedirect()
      ✔ should throw an unsupported error
    reauthenticateWithPhoneNumber()
      ✔ should throw an unsupported error
    reauthenticateWithPopup()
      ✔ should throw an unsupported error
    reauthenticateWithRedirect()
      ✔ should throw an unsupported error
    refreshToken
      ✔ should throw an unsupported error
    user.metadata
      ✔ should have the properties 'lastSignInTime' & 'creationTime' which are ISO strings

[...]

  messaging()
    namespace
      ✔ accessible from firebase.app()
    setAutoInitEnabled()
      ✔ throws if enabled is not a boolean
      ✔ sets the value
    isDeviceRegisteredForRemoteMessages
      - returns true on android
      ✔ defaults to false on ios before registering
    unregisterDeviceForRemoteMessages
      - resolves on android, remains registered
      ✔ successfully unregisters on ios
    hasPermission
      - returns true android (default)
      ✔ returns -1 on ios (default)
    requestPermission
      - resolves 1 on android
    getAPNSToken
      - resolves null on android
      ✔ resolves null on ios if using simulator
    unsupported web sdk methods
      ✔ useServiceWorker should not error when called
      ✔ usePublicVapidKey should not error when called
    getInitialNotification
      ✔ returns null when no initial notification
    deleteToken()
      ✔ generate a new token after deleting
    onMessage()
      ✔ throws if listener is not a function
      - receives messages when the app is in the foreground
    onTokenRefresh()
      ✔ throws if listener is not a function
    onDeletedMessages()
      ✔ throws if listener is not a function
    onMessageSent()
      ✔ throws if listener is not a function
    onSendError()
      ✔ throws if listener is not a function
    setBackgroundMessageHandler()
      ✔ throws if handler is not a function
      - receives messages when the app is in the background
    subscribeToTopic()
      ✔ throws if topic is not a string
      ✔ throws if topic contains a /
    unsubscribeFromTopic()
      ✔ throws if topic is not a string
      ✔ throws if topic contains a /

  messaging().sendMessage(*)
    ✔ throws if used on ios
    - throws if no object provided
    - uses default values
    to
      - throws if to is not a string
      - accepts custom to value
    messageId
      - throws if messageId is not a string
      - accepts custom messageId value
    ttl
      - throws if not a number
      - throws if negative number
      - throws if float number
      - accepts custom ttl value
    data
      - throws if data not an object
      - accepts custom data value
    collapseKey
      - throws if collapseKey is not a string
      - accepts custom collapseKey value
    messageType
      - throws if messageType is not a string
      - accepts custom messageType value

[...]

  inAppMessaging()
    namespace
      ✔ accessible from firebase.app()
    setAutomaticDataCollectionEnabled()
18:15:11.739 detox[23952] WARN:  at e2e/init.js:41:15
 ⚠️ A test failed:
18:15:11.739 detox[23952] WARN:  at e2e/init.js:42:15
 ️   ->  true
18:15:11.740 detox[23952] WARN:  at e2e/init.js:49:13
 ️   ->  Retrying in 5 seconds ... (1)
      ✔ true
      ✔ false
      ✔ errors if not boolean
    setMessagesDisplaySuppressed()
      - false
      - true
      - errors if not boolean
    triggerEvent()
      - no exceptions thrown

[...]

  1056 passing (2m)
  72 pending

✨  Done in 131.73s.

Think react-native-firebase is great? Please consider supporting the project with any of the below:

👉 Star this repo on GitHub ⭐️
👉 Follow React Native Firebase and Invertase on Twitter

🔥

vercel · 2022-07-15T22:22:13Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
react-native-firebase	✅ Ready (Inspect)	Visit Preview	Aug 5, 2022 at 9:19PM (UTC)

1 Ignored Deployment

Name	Status	Preview	Updated
react-native-firebase-next	⬜️ Ignored (Inspect)		Aug 5, 2022 at 9:19PM (UTC)

codecov · 2022-07-15T22:27:05Z

Codecov Report

Merging #6392 (8b46c5b) into main (254f9fc) will decrease coverage by 46.49%.
The diff coverage is 0.00%.

❗ Current head 8b46c5b differs from pull request most recent head fced716. Consider uploading reports for the commit fced716 to get more accurate results

@@             Coverage Diff             @@
##             main    #6392       +/-   ##
===========================================
- Coverage   72.31%   25.83%   -46.48%     
===========================================
  Files         109       97       -12     
  Lines        4655     4291      -364     
  Branches     1048     1048               
===========================================
- Hits         3366     1108     -2258     
- Misses       1211     2583     +1372     
- Partials       78      600      +522

mikehardy · 2022-07-17T17:42:05Z

Oh wow! This is Ninja level work, thank you! I'm travelling and only mobile phone at the moment but will merge as soon as I can give it a good look

glesperance · 2022-07-17T18:01:56Z

haha thanks @mikehardy. Lmk if I can be of any help!

glesperance · 2022-07-26T20:03:09Z

@mikehardy any news about this?

mikehardy

Hey there - sorry for the delay, when I say traveling I meant really traveling, I'm changing city about every 2 days on average, have been for a few weeks and will be for a few weeks more, with quite intermittent network connections. So I do appreciate your patience while you bear with me not being a great collaborator at the moment

That said, I left a comment where I'm basically just looking for some reference as I can't do a good review without understanding how that conditional is working. In general it seems like a fine idea but only with an understanding of the conditional

mikehardy · 2022-07-30T21:20:27Z

packages/messaging/ios/RNFBMessaging/RNFBMessaging+AppDelegate.m

@@ -123,6 +123,18 @@ - (void)application:(UIApplication *)application
    completionHandler(UIBackgroundFetchResultNoData);
    return;
  }
+
+  // If the notification is a probe notification, always call the completion 


is there some documentation about what a probe notification is? First I have heard of it! It seems to be detectable (via your data && data[@"warning"] test but I'd love a canonical source for that test as nothing came up in my attempt at a search

Good question & sorry if I put pressure on you :)
This can wait for you to be back to normal, I just would hate this bug to be in the codebase.

Regarding the probe notification, I haven't found it through the documentation but rather through inspecting the Firebase iOS SDK code.

https://github.com/firebase/firebase-ios-sdk/blob/eb30b6fdd809cbfe3a9eb7f3ccf1dd46326bef2d/FirebaseAuth/Sources/SystemService/FIRAuthNotificationManager.m#L105-L110

https://github.com/firebase/firebase-ios-sdk/blob/eb30b6fdd809cbfe3a9eb7f3ccf1dd46326bef2d/FirebaseAuth/Sources/SystemService/FIRAuthNotificationManager.m#L45-L48

I looked at the blame log and this was part of the iOS Firebase SDK's first commit ever.

The fix has been found through dissecting the code until I found most minimal cause of the bug, and then got a matching fix.

Perhaps @paulb777 (the original author of the SDK) could give us some details?

I did the original open sourcing, but not the authoring so I can't help with the purpose of FirebaseAuth probe notifications, but maybe @renkelvin can?

Hi all, I'm not the author either, while my understanding is that this key is to help Firebase Auth to decide whether they should handle the notification or let the App handle it. See https://github.com/firebase/firebase-ios-sdk/blob/eb30b6fdd809cbfe3a9eb7f3ccf1dd46326bef2d/FirebaseAuth/Sources/SystemService/FIRAuthNotificationManager.m#L150

thanks @paulb777 @renkelvin (that was some awesomely quick feedback)! This definitely brings me back to when I found the fix.

@mikehardy I should have taken notes when I made the original fix, but my understanding was that (thank you Paul & Chuanr for jogging my memory back) we should always callback when we receive a probe notification, since that is what the SDK does when it has pending callbacks:

https://github.com/firebase/firebase-ios-sdk/blob/eb30b6fdd809cbfe3a9eb7f3ccf1dd46326bef2d/FirebaseAuth/Sources/SystemService/FIRAuthNotificationManager.m#L150-L158

Moreover, even if we redundantly call there would be no side effect to call the completion handler since it is effectively no-op:
https://github.com/firebase/firebase-ios-sdk/blob/eb30b6fdd809cbfe3a9eb7f3ccf1dd46326bef2d/FirebaseAuth/Sources/SystemService/FIRAuthNotificationManager.m#L116-L117

Therefore the thinking is:

we get a probe notification; and RNFB can't handle it.

assuming that detox waits for completion handlers to be called back to say things are complete (not an unfair assumption for us & detox); we can't just drop the notification and never call the completion handler.

Even if we redundantly call back the completion handler --> there is no side effect.

therefore just always call back the completion handler when it's a probe notification.

@Salakar or @Ehesp just dropping you a notification that links you into some really interesting firebase messaging / auth race condition that is deep enough / subtle enough it probably lives in FlutterFire too - you might take a look. I hate to create new notification pings just for gratitude when we probably get too many, but I'll do it anyway, thanks @paulb777 and @renkelvin for the assist here, much appreciated.

…oteNotification` and this module causing detox to hang when `FIRAuth/didReceiveRemoteNotification` is called first. see https://stackoverflow.com/questions/72044950/detox-tests-hang-with-pending-items-on-dispatch-queue/72989494

…e notification

glesperance · 2022-08-05T23:30:46Z

@mikehardy just pushed a 2nd commit fixing an issue when the received notification data is a JSON string. I noticed some crashes in our production build related to the fix in the PR.

I then realized we were missing the deserialization logic:
https://github.com/firebase/firebase-ios-sdk/blob/eb30b6fdd809cbfe3a9eb7f3ccf1dd46326bef2d/FirebaseAuth/Sources/SystemService/FIRAuthNotificationManager.m#L141-L149

fced716 fixes that.

mikehardy · 2022-08-05T23:39:46Z

I'm so sorry I've been a slow collaborator on this - I'm still traveling and haven't found a sufficient time slice to be useful digitally for a couple weeks. I really appreciate you've moved this forward but I probably won't have time to integrate for maybe a week. Have you tried the patch package zip set for it off the GitHub actions? There is a small problem halting full release at the moment but it's in new functionality ( firestore geopoint toJSON, a really minor new API) so there should be no problems integrating it safely

mikehardy

this looks good, I appreciate the digging so I could understand it ("Today I learned...") and the second commit seems to make it as safe as I can currently imagine. Got some free in flight wifi and a quick moment to run through react-native-firebase PRs pending merge so hopefully I can get everything through CI and kick off the release with this in it. Thanks!

mikehardy · 2022-08-07T19:18:22Z

Hey - nothing personal, I just don't have commit rights to this branch on your repo (frequently PR authors assign those to maintainers but it's totally fair play not to, no worries) and I need to commit result of yarn lint:ios:fix and a rebase against main to get CI clean for merge. So I've done those two things and pushed to a branch on main repo for a CI run - this will be superceded by #6455

mikehardy · 2022-08-07T20:06:27Z

CI went green on the superceding PR, commits carried on to main now via squash merge - launching shortly - thanks again

glesperance · 2022-08-08T14:20:52Z

No problem! I'll set those rights for next time.

Thanks for the merge @mikehardy!

vercel bot deployed to Preview – react-native-firebase July 15, 2022 22:26 View deployment

mikehardy added type: bug New bug report platform: ios Workflow: Needs Review Pending feedback or review from a maintainer. labels Jul 17, 2022

mikehardy reviewed Jul 30, 2022

View reviewed changes

mikehardy added Workflow: Waiting for User Response Blocked waiting for user response. and removed Workflow: Needs Review Pending feedback or review from a maintainer. labels Jul 30, 2022

glesperance force-pushed the fix/messaging-didReceiveRemoteNotification-race branch from 941128b to 41c7805 Compare August 5, 2022 20:58

glesperance force-pushed the fix/messaging-didReceiveRemoteNotification-race branch from 41c7805 to 6a9d3d3 Compare August 5, 2022 21:00

vercel bot deployed to Preview – react-native-firebase August 5, 2022 21:09 View deployment

fix(messaging): messaging crashing if receiving JSON data for firebas…

fced716

…e notification

vercel bot deployed to Preview – react-native-firebase August 5, 2022 21:19 View deployment

mikehardy approved these changes Aug 7, 2022

View reviewed changes

mikehardy mentioned this pull request Aug 7, 2022

fix(messaging, ios): eliminate auth/messaging notification race #6455

Merged

8 tasks

mikehardy closed this Aug 7, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(messaging): Fixes a race condition between `FIRAuth/didReceiveRem… #6392

fix(messaging): Fixes a race condition between `FIRAuth/didReceiveRem… #6392

glesperance commented Jul 15, 2022

vercel bot commented Jul 15, 2022 •

edited

Loading

codecov bot commented Jul 15, 2022 •

edited

Loading

mikehardy commented Jul 17, 2022

glesperance commented Jul 17, 2022

glesperance commented Jul 26, 2022

mikehardy left a comment

mikehardy Jul 30, 2022

glesperance Aug 2, 2022

paulb777 Aug 2, 2022

renkelvin Aug 3, 2022

glesperance Aug 3, 2022 •

edited

Loading

mikehardy Aug 7, 2022

glesperance commented Aug 5, 2022 •

edited

Loading

mikehardy commented Aug 5, 2022

mikehardy left a comment

mikehardy commented Aug 7, 2022

mikehardy commented Aug 7, 2022

glesperance commented Aug 8, 2022

fix(messaging): Fixes a race condition between `FIRAuth/didReceiveRem… #6392

fix(messaging): Fixes a race condition between `FIRAuth/didReceiveRem… #6392

Conversation

glesperance commented Jul 15, 2022

Description

Related issues

Release Summary

Checklist

Test Plan

vercel bot commented Jul 15, 2022 • edited Loading

codecov bot commented Jul 15, 2022 • edited Loading

Codecov Report

mikehardy commented Jul 17, 2022

glesperance commented Jul 17, 2022

glesperance commented Jul 26, 2022

mikehardy left a comment

Choose a reason for hiding this comment

mikehardy Jul 30, 2022

Choose a reason for hiding this comment

glesperance Aug 2, 2022

Choose a reason for hiding this comment

paulb777 Aug 2, 2022

Choose a reason for hiding this comment

renkelvin Aug 3, 2022

Choose a reason for hiding this comment

glesperance Aug 3, 2022 • edited Loading

Choose a reason for hiding this comment

mikehardy Aug 7, 2022

Choose a reason for hiding this comment

glesperance commented Aug 5, 2022 • edited Loading

mikehardy commented Aug 5, 2022

mikehardy left a comment

Choose a reason for hiding this comment

mikehardy commented Aug 7, 2022

mikehardy commented Aug 7, 2022

glesperance commented Aug 8, 2022

vercel bot commented Jul 15, 2022 •

edited

Loading

codecov bot commented Jul 15, 2022 •

edited

Loading

glesperance Aug 3, 2022 •

edited

Loading

glesperance commented Aug 5, 2022 •

edited

Loading