chore(lint, ios): fix xcode warnings wherever possible

[mikehardy]

Description

Our iOS build was getting pretty noisy, this quiets it down. Still one that we could potentially get rid of but the rest are from upstream in firebase-ios-sdk

Related issues

Release Summary

conventional commits -> rebase merge

Checklist

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • Yes
• My change supports the following platforms;
  • Android
  • iOS
• My change includes tests;
  • e2e tests added or updated in packages/\*\*/e2e
  • jest tests added or updated in packages/\*\*/__tests__
• I have updated TypeScript types that are affected by my change.
• This is a breaking change;
  • Yes
  • No

Test Plan

Compile should pass with very few compile warnings, all e2e should pass

---

Think react-native-firebase is great? Please consider supporting the project with any of the below:

• 👉 Star this repo on GitHub ⭐️
• 👉 Follow React Native Firebase and Invertase on Twitter

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

react-native-firebase – ./

🔍 Inspect: https://vercel.com/invertase/react-native-firebase/2Tm3LpBPvv9YBCEc4Dy5WvGrkDkk
✅ Preview: https://react-native-firebase-git-mikehardy-xcode-warnings-invertase.vercel.app

react-native-firebase-next – ./website_modular

🔍 Inspect: https://vercel.com/invertase/react-native-firebase-next/E3HqYT8wVn1CCYDsYEW35zWRgAtp
✅ Preview: Canceled

[Deployment for 57d59d7 canceled]

[codecov]

Codecov Report

Merging #6061 (68912e4) into main (211b753) will decrease coverage by 0.05%.
The diff coverage is 95.00%.

❗ Current head 68912e4 differs from pull request most recent head 57d59d7. Consider uploading reports for the commit 57d59d7 to get more accurate results

@@             Coverage Diff              @@
##               main    #6061      +/-   ##
============================================
- Coverage     53.01%   52.96%   -0.04%     
+ Complexity      628      622       -6     
============================================
  Files           208      208              
  Lines         10205    10214       +9     
  Branches       1623     1626       +3     
============================================
  Hits           5409     5409              
- Misses         4545     4551       +6     
- Partials        251      254       +3     

[mikehardy]

a continuation / completion of #5935 really - after they were really visible it was easy to tamp things down all the way

[mikehardy]

Chasing upstream warnings here firebase/firebase-ios-sdk#9331