test(e2e, android): forward-port test app to targetSdkVersion 31 #5835
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was proposed in #5834 that the modules did not work with Android 12
I showed in mikehardy/rnfbdemo@218f551#diff-3e27ae623577d0c559bd8ab973a0c34af8cc65ef9beb9868a9cdb029854f8078 that it could work
...but forward-porting our own internal test app to api31 is the best way to show it works
It was seemless except for Detox relying on non-Android12 compatible transitives
Required a patch to Detox, tracked here:
wix/Detox#3055
Test Plan
It works locally, if it passes CI it's good
Think
react-native-firebase
is great? Please consider supporting the project with any of the below:React Native Firebase
andInvertase
on Twitter