Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(e2e, android): forward-port test app to targetSdkVersion 31 #5835

Merged
merged 1 commit into from
Nov 5, 2021

Conversation

mikehardy
Copy link
Collaborator

It was proposed in #5834 that the modules did not work with Android 12

I showed in mikehardy/rnfbdemo@218f551#diff-3e27ae623577d0c559bd8ab973a0c34af8cc65ef9beb9868a9cdb029854f8078 that it could work

...but forward-porting our own internal test app to api31 is the best way to show it works

It was seemless except for Detox relying on non-Android12 compatible transitives

Required a patch to Detox, tracked here:
wix/Detox#3055

Test Plan

It works locally, if it passes CI it's good


Think react-native-firebase is great? Please consider supporting the project with any of the below:

@vercel
Copy link

vercel bot commented Nov 5, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

react-native-firebase – ./

🔍 Inspect: https://vercel.com/invertase/react-native-firebase/3urYRYv2SsAKZvm6CEQQrJ8aoquH
✅ Preview: https://react-native-firebase-git-mikehardy-android12-invertase.vercel.app

react-native-firebase-next – ./website_modular

🔍 Inspect: https://vercel.com/invertase/react-native-firebase-next/B8mUmBUX2hn6Bf7fGo27fdwNcbbq
✅ Preview: Canceled

@mikehardy mikehardy added the Workflow: Pending Merge Waiting on CI or similar label Nov 5, 2021
@codecov
Copy link

codecov bot commented Nov 5, 2021

Codecov Report

Merging #5835 (32c8fbf) into main (4871131) will increase coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 32c8fbf differs from pull request most recent head edbcca8. Consider uploading reports for the commit edbcca8 to get more accurate results

@@             Coverage Diff              @@
##               main    #5835      +/-   ##
============================================
+ Coverage     52.98%   53.00%   +0.02%     
  Complexity      620      620              
============================================
  Files           208      208              
  Lines         10118    10118              
  Branches       1589     1589              
============================================
+ Hits           5360     5362       +2     
+ Misses         4503     4501       -2     
  Partials        255      255              

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant