Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(FAQ): add info re: disabling debugger for test crashes under Xcode #4912

Merged
merged 2 commits into from
Feb 18, 2021

Conversation

Frank1234
Copy link
Contributor

FAQ Update on Xcode debugger problem when faking a crash.

#4014

Added solution for this problem: invertase#4014
@CLAassistant
Copy link

CLAassistant commented Feb 15, 2021

CLA assistant check
All committers have signed the CLA.

@vercel
Copy link

vercel bot commented Feb 15, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/invertase/react-native-firebase/aj795qsoh
✅ Preview: https://react-native-firebase-git-fork-frank1234-patch-1.invertase.vercel.app

mikehardy
mikehardy previously approved these changes Feb 16, 2021
Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@mikehardy mikehardy changed the title FAQ Update on Xcode debugger problem docs(FAQ): add info re: disabling debugger for test crashes under Xcode Feb 16, 2021
@mikehardy
Copy link
Collaborator

@Frank1234 this is good to go except we don't seem to have a valid CLA signed for you - could you follow the "details" link in the checks block to resolve that? Then I can merge. Thanks!

https://cla-assistant.io/invertase/react-native-firebase?pullRequest=4912

@mikehardy
Copy link
Collaborator

I see the CLA is signed now, merge! :-) thanks again

@mikehardy mikehardy merged commit 6bf8ee5 into invertase:master Feb 18, 2021
@mikehardy mikehardy removed the Workflow: Pending Merge Waiting on CI or similar label Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants