-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: dependency updates, related fixes #4711
Conversation
Note that the breaking change was in #4471 and was called out in release notes This is just a remnant where the pod utilities will likely give you more notice about it
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/invertase/react-native-firebase/oeh46ps6l |
The only thing of concern here for review is the alteration in |
Codecov Report
@@ Coverage Diff @@
## master #4711 +/- ##
==========================================
+ Coverage 85.43% 89.09% +3.67%
==========================================
Files 109 109
Lines 3712 3712
Branches 347 347
==========================================
+ Hits 3171 3307 +136
+ Misses 475 363 -112
+ Partials 66 42 -24 |
also switched 'yarn run' to 'yarn', yarn does not need run now
9de147c
to
a593054
Compare
any step that uses network resources should be in a retry to reduce flakiness
I have successfully test-integrated the patch-package test set in my work app as a cross-check, everything still working |
c040ff8
to
13b56df
Compare
one in particular was enabled and failing CI, the rest should work now that I correctly handle callback delay and local firestore persistence by using random collections
13b56df
to
8916e19
Compare
Test integration with my work app (which uses all of this except admob/ml/database) works well in local emulators, real devices and my developer teammates devices'. Even the typing changes are intended to be non-functional and those can be fixed post-hoc if needed, going to put this in and move forward |
I wasn't able to get superstruct forward-port working, I have a local commit that can either work in unit tests or in e2e tests but not both at the same time due to the way tests configures the metro packager I think. Will post it for consideration / help shortly |
Description
The package.json in root and tests were going pretty stale
This brings them all up to date along with associated fixes to handle major version breaking changes in dependencies
There is still one dependency out of date - superstruct, I'm going to attempt to forward port that one as well but this is merge-able as is. If I forward port it successfully I'll remove this
Release Summary
each commit has it's own conventional commit message
Checklist
Android
iOS
e2e
tests added or updated inpackages/\*\*/e2e
jest
tests added or updated inpackages/\*\*/__tests__
Test Plan
Think
react-native-firebase
is great? Please consider supporting the project with any of the below:React Native Firebase
andInvertase
on Twitter