Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(remote-config)!: fetchAndActivate API & activate API update #4157

Merged
merged 1 commit into from
Aug 28, 2020

Conversation

russellwheatley
Copy link
Member

@russellwheatley russellwheatley commented Aug 27, 2020

Description

Updated iOS to match Android & Web. Updated types as well as documentation.

Web documentation & Android documentation indicate:

  • fetchAndActivate - should return false when local config values are up to date with backend config values.
  • activate - should return false when all local config values are already activated.

Related issues

fixes #2767

Release Summary

  • fetchAndActivate

    • Previous behaviour returned a boolean indicating if config values were activated
    • New behaviour returns a boolean indicating if any config values were fetched remotely.
  • activate

    • Previous behaviour returned a boolean indicating if config values were activated
    • New behaviour returns a boolean indicating if any local config values were activated.

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Think react-native-firebase is great? Please consider supporting the project with any of the below:

@vercel
Copy link

vercel bot commented Aug 27, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/invertase/react-native-firebase/eqgnbg5yn
✅ Preview: https://react-native-firebase-git-russell-remote-config.invertase.vercel.app

@mikehardy mikehardy changed the title fix(remote-config): fetchAndActivate API & activate API update fix(remote-config)!: fetchAndActivate API & activate API update Aug 27, 2020
@russellwheatley russellwheatley marked this pull request as ready for review August 28, 2020 08:56
@russellwheatley russellwheatley merged commit 9058dca into master Aug 28, 2020
@russellwheatley russellwheatley deleted the @russell/remote-config branch August 28, 2020 10:05
@Salakar
Copy link
Contributor

Salakar commented Aug 28, 2020

That wasn't merged as a breaking change on master, also missing the commit message body describing the breaking behaviour: #4157 (comment)

@Salakar
Copy link
Contributor

Salakar commented Aug 28, 2020

Not much we can do about it now but could update the changelog manually after its released I think

@mikehardy
Copy link
Collaborator

I'll do a quick PR to remote-config that is just for breaking / release notes auto-goodness, I want the version number to bump correctly it's not just a release notes deal. Small break but still

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[6.0.x] Remote config fetch/fetchAndActivate never resolves on Android
3 participants