-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use @import Firebase; instead of #import <Firebase.h> #4069
Conversation
Continue to use @import Firebase instead of #import <Firebase.h> who failed to archive on IOS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do this in my demo generator and it seems to work fine
https://github.com/mikehardy/rnfbdemo/blob/eda24a71990e95e8a91b17b27b0cc1417031808b/make-demo.sh#L19
However @Lucas-Geitner I do the old style in my work project and it also works fine
This causes you to fail to archive - using the old style?
Yes exactly, when i Archive (with fastlane) it throw an error. It doesn't with the old way. |
Very interesting. With my demo script (using With my work project I use Why the difference? 🤔 |
Hello @mikehardy, Thanks for you fast answer; It's a production app built with a fresh fresh new react-native 0.63 app , unfortunately, i cannot share the source code with you. This is the error i got:
Tell me if i can help in any way |
I found why it didn't work, it have nothing to do with React Native Firebase 😄, This is a related issue zoontek/react-native-bootsplash#139 👉🏻 There is now a condition in appDelegate.m in react-native 0.63 my import was after this condition. I think we can close this issue or improved the documentation if you think you won't have any case like mine, Thanks !
|
That makes a lot more sense, whew! I'm not great at Objective-C but I couldn't understand this one. There is a tips-and-tricks section on rnfirebase.io, you might add a new case "My app no longer compiles after upgrading to react-native 0.63, can't find firebase" (or the specific error, whatever it is) and then the explanation |
Continue to use @import Firebase instead of #import <Firebase.h> who failed to archive on IOS