Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed references to setUserName and setUserEmail in Crashlytics docs #3909

Merged
merged 1 commit into from
Jul 9, 2020
Merged

Removed references to setUserName and setUserEmail in Crashlytics docs #3909

merged 1 commit into from
Jul 9, 2020

Conversation

emeraldsanto
Copy link
Contributor

@emeraldsanto emeraldsanto commented Jul 8, 2020 •
edited by mikehardy
Loading

Description

There was a part of the Crashlytics documentation which was outdated as of the latest release (8.1.1).

Related issues

Fixes #3908

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

@CLAassistant
Copy link

CLAassistant commented Jul 8, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@emeraldsanto emeraldsanto mentioned this pull request Jul 8, 2020
Closed
mikehardy
mikehardy approved these changes Jul 8, 2020
View reviewed changes
Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@mikehardy mikehardy requested a review from Ehesp July 8, 2020 20:01
@emeraldsanto
Copy link
Contributor Author

Also noticed that the Conributing Guideline link actually takes me to Github's careers page 😅

@andersonaddo andersonaddo linked an issue Jul 8, 2020 that may be closed by this pull request
Crashlytics documentation for setUserName and setUserEmail is possibly outdated #3908
Closed
mikehardy added a commit that referenced this pull request Jul 8, 2020
@mikehardy
docs: link CONTRIBUTING correctly in PR template
f220423 
As noticed and pointed out by @emeraldsanto on #3909
@mikehardy mikehardy mentioned this pull request Jul 8, 2020
Merged
@mikehardy
Copy link
Collaborator

Thanks - @andersonaddo I used the auto-linking "Fixes #xxx" in a direct update to the PR and thanks @emeraldsanto I posted a PR to fix the PR template (how meta...)

@emeraldsanto
Copy link
Contributor Author

Always happy to help!

@Salakar
Copy link
Contributor

Salakar commented Jul 9, 2020

Thank you :)

@Salakar Salakar merged commit 9b73e0a into invertase:master Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikehardy mikehardy mikehardy approved these changes

@Salakar Salakar Salakar approved these changes

@Ehesp Ehesp Awaiting requested review from Ehesp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crashlytics documentation for setUserName and setUserEmail is possibly outdated
4 participants
@emeraldsanto @CLAassistant @mikehardy @Salakar