feat(auth): linkDomain support for ActionCodeSettings

[MichaelVerdon]

Description

Related issues

Release Summary

Checklist

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • Yes
• My change supports the following platforms;
  • Android
  • iOS
• My change includes tests;
  • e2e tests added or updated in packages/\*\*/e2e
  • jest tests added or updated in packages/\*\*/__tests__
• I have updated TypeScript types that are affected by my change.
• This is a breaking change;
  • Yes
  • No

Test Plan

---

Think react-native-firebase is great? Please consider supporting the project with any of the below:

• 👉 Star this repo on GitHub ⭐️
• 👉 Follow React Native Firebase and Invertase on Twitter

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
react-native-firebase	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 19, 2025 3:13pm

[russellwheatley]

@mikehardy - when I was writing unit tests, the User was mismatched with the FirebaseAuthTypes.User type (nice benefit of tests in TS). So I had a look and realised reauthenticateWithProvider isn't a method on RNFB User, it is an underlying method on native: https://github.com/invertase/react-native-firebase/blob/main/packages/auth/lib/User.js#L123

Hence the type update here.

However, these two methods don't exist on firebase-js-sdk: https://github.com/invertase/react-native-firebase/blob/main/packages/auth/lib/User.js#L116-L125

They don't exist on iOS or android either. The method I replaced in this type declaration reauthenticateWithProvider() does exist on iOS though: https://firebase.google.com/docs/reference/ios/firebaseauth/api/reference/Classes/FIRUser?#-reauthenticatewithprovider:uidelegate:completion:

For reference:

web User: https://firebase.google.com/docs/reference/js/auth.user?_gl=1*9u2tmx*_up*MQ..*_ga*MjAxNDk4MDUxOC4xNzM5NTI5OTg1*_ga_CW55HF8NVT*MTczOTUyOTk4NS4xLjAuMTczOTUyOTk4NS4wLjAuMA..

android User: https://firebase.google.com/docs/reference/android/com/google/firebase/auth/FirebaseUser?_gl=1*doepw2*_up*MQ..*_ga*MTg5MjAwNjM3LjE3Mzk3OTc5MTk.*_ga_CW55HF8NVT*MTczOTc5NzkxOS4xLjAuMTczOTc5NzkxOS4wLjAuMA..

Not sure what to do about that, not for this PR in any event but something we should possibly address.

[mikehardy]

@russellwheatley

I think reauthenticateWithPopup(auth, provider, resolver?): Promise<UserCredential> is the closest map as that has the return type we want even if we will never use the resolver

https://firebase.google.com/docs/reference/js/auth.md#reauthenticatewithpopup_41c0b31

using reauthenticateWithRedirect is an even bigger API mis-match as it has no return and implies they need to call some other method to get the result

focused on the modular API here at least, namespaced should be similar?

[russellwheatley]

the modular API is fine as it is, we have methods for reauthenticateWithRedirect() & reauthenticateWithPopup()

Implementation:
https://github.com/invertase/react-native-firebase/blob/deprecation_warnings_dynamic_links/packages/auth/lib/modular/index.d.ts#L540-L554

with corresponding types:
https://github.com/invertase/react-native-firebase/blob/deprecation_warnings_dynamic_links/packages/auth/lib/modular/index.d.ts#L540-L554

The issue we have is actually there are two methods on namespaced User API which don't have a type on namespaced type declaration:

https://github.com/invertase/react-native-firebase/blob/deprecation_warnings_dynamic_links/packages/auth/lib/User.js#L117-L122

Instead, we have a type that isn't available on namespaced User (note: this is pointing to main branch): https://github.com/invertase/react-native-firebase/blob/main/packages/auth/lib/index.d.ts#L1363

The fix is to create types for those two namespaced methods and remove the type declaration for a method that doesn't exist for the namespaced user. I should have just done this in the first place 🙏

Hopefully the above makes sense 😄

[russellwheatley]

Actually, I take it back. I think you're right. I think this method is a bit misleading and should probably throw an exception (something like "web API is unsupported at this moment"): https://github.com/invertase/react-native-firebase/blob/deprecation_warnings_dynamic_links/packages/auth/lib/index.js#L422

it should probably be reauthenticateWithPopup() that we use I think.

[mikehardy]

I think there may be a better API fit, but I looked in modular JS reference, just realized there is not actually a modular implementation here but it should be on auth and exported ? Unsure if it is

My comment still stands for the namespaced API though, as the Popup flavor has the return type we want there as well

https://firebase.google.com/docs/reference/js/v8/firebase.User#reauthenticatewithpopup

Other than that I think the implementation of the actual feature you were implementing looks pretty good?

[mikehardy]

yarn lint:android will probably alter this one and return exit code 1 prompting for a fix?
I noticed on remote-config feature custom signals there is a false positive on android lint, because that one had formatting issues as well but CI was just fine with them...will look at that separately

[mikehardy]

Fantastic