fix(storage): expose static types for modular API

[russellwheatley]

Description

Related issues

Release Summary

Checklist

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • Yes
• My change supports the following platforms;
  • Android
  • iOS
• My change includes tests;
  • e2e tests added or updated in packages/\*\*/e2e
  • jest tests added or updated in packages/\*\*/__tests__
• I have updated TypeScript types that are affected by my change.
• This is a breaking change;
  • Yes
  • No

Test Plan

---

Think react-native-firebase is great? Please consider supporting the project with any of the below:

• 👉 Star this repo on GitHub ⭐️
• 👉 Follow React Native Firebase and Invertase on Twitter

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
react-native-firebase	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 13, 2025 8:45am

[mikehardy]

I did a little fixup here to make this work (by adding the export here and removing the export below)
but the other two statics PRs would not have the export here, they would leave it in modular only

[russellwheatley]

good catch 👍 . I've also updated tests for static properties which I've done for others as well (using intellisense to pick up type properties as POC 😄 )

[russellwheatley]

actually, I think we should remove the static export from here, it should be from modular only in my view

[mikehardy]

So my fixup here quieted one error but I wasn't sure on it - and I like your way of thinking better

Action - the export here should be removed, and statics should just go into the registry function for namespace attachment

[mikehardy]

Huh - that appears to have caused a real issue:

         firebase v8 compatibility
           "before all" hook in "firebase v8 compatibility":
     TypeError: Cannot read property 'StringFormat' of undefined
      at putString (/home/runner/work/react-native-firebase/react-native-firebase/packages/storage/lib/StorageReference.js:201:43)
      at seed (/home/runner/work/react-native-firebase/react-native-firebase/packages/storage/e2e/helpers.js:14:59)
      at asyncGeneratorStep (/home/runner/work/react-native-firebase/react-native-

enhancement thought - but not on this PR - need to get those e2e tests in to typescript and have the type check as part of our lint checks which are fast enough to run locally and faster in CI

[mikehardy]

@russellwheatley I pushed a maybe-final commit here that adjusts this types PR to follow your thinking on the other two

• no export of statics directly from namespaced
• yes to your export of specific items from statics-file in modular

...and I adjusted the use of statics internally so they handle the new export style from the statics-file so it should pass e2e now

what do you think?

[russellwheatley]

@mikehardy - yes, we're in agreement 🙏. Should hopefully go green now, there was one remaining pesky default export in that StorageReference file.

[mikehardy]

A thing of beauty