Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(remote-config, ios): avoid double-resolve when setting custom signals #8312

Merged

Conversation

mikehardy
Copy link
Collaborator

@mikehardy mikehardy commented Feb 10, 2025

Description

The iOS code for the new custom signals feature has multiple pathways that can resolve, leading to a redbox error on ios devices

I missed that in review

Related issues

PR related:

Release Summary

single conventional commit

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan

Saw the error while checking test results, fixing this removes the redbox, tests still pass


Think react-native-firebase is great? Please consider supporting the project with any of the below:

Copy link

vercel bot commented Feb 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 10, 2025 7:41pm

@russellwheatley russellwheatley changed the title fix:remote-config, ios): avoid double-resolve when setting custom signals fix(remote-config, ios): avoid double-resolve when setting custom signals Feb 11, 2025
@mikehardy mikehardy merged commit 16bad75 into main Feb 11, 2025
18 of 21 checks passed
@mikehardy mikehardy deleted the @mikehardy/remote-config-custom-signal-double-resolve branch February 11, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: ios plugin: remote_config Firebase Remote Config Workflow: Needs Review Pending feedback or review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants