-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(firestore): expose modular Filter
and it's proper types
#7884
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7884 +/- ##
===========================================
+ Coverage 25.38% 67.87% +42.50%
===========================================
Files 154 154
Lines 6137 6137
Branches 1266 1266
===========================================
+ Hits 1557 4165 +2608
+ Misses 3917 1868 -2049
+ Partials 663 104 -559 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ideally a simple test would be good here to ensure this export is there and functions
Description
Tested with the following:
also get proper typing for

Filter
:Related issues
fixes #7134
Release Summary
Checklist
Android
iOS
e2e
tests added or updated inpackages/\*\*/e2e
jest
tests added or updated inpackages/\*\*/__tests__
Test Plan
Think
react-native-firebase
is great? Please consider supporting the project with any of the below:React Native Firebase
andInvertase
on Twitter