Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(functions): typescript definitions for modular functions API #7777

Merged
merged 2 commits into from
May 8, 2024
Merged

feat(functions): typescript definitions for modular functions API #7777

merged 2 commits into from
May 8, 2024

Conversation

skam22
Copy link
Contributor

@skam22 skam22 commented May 3, 2024

Description

typescript definitions for modular functions API.

Related issues

Release Summary

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan


@mikehardy since you asked.
Think react-native-firebase is great? Please consider supporting the project with any of the below:

Copy link

vercel bot commented May 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 3, 2024 9:29pm

@mikehardy
Copy link
Collaborator

Hey that's unexpected and amazing, thank you! Traveling right now but can hopefully get this in really quickly

@mikehardy mikehardy added the Workflow: Needs Review Pending feedback or review from a maintainer. label May 4, 2024
Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is excellent work - I really appreciate it

@mikehardy mikehardy merged commit e724a46 into invertase:main May 8, 2024
14 of 17 checks passed
@mikehardy mikehardy removed the Workflow: Needs Review Pending feedback or review from a maintainer. label May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants