-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(app-check, android): Implement app check token change listener #7309
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@mikehardy @InvertaseBot Is an anything I need todo to get reviewed ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! The native implementation looks great - I especially like that you correctly handled the destruction of the catalyst instance ✅
At the javascript level it looks like we need a little bit of change here in order to comply with the firebase-js-sdk app-check contract, where they allow for multiple listeners for the same app, and their typings are a bit different. Here in react-native-firebase we must be a drop-in replacement for firebase-js-sdk where ever possible and I think in this case we can meet their behavior (multiple listeners) and typings,. What do you think?
@mikehardy I've updated onTokenChanged to match params same as firebase js sdk, But onError. onCompletion isn't used, I've checked firebase class docs and it doesn't support passing error callback or throw error, Same thing if you check |
@mikehardy Done 💯 I added support for multiple listeners and reset all commits into 1 to make it cleaner |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good, thanks for handling the comments, and so quickly.
I think lint is going to be a bit annoyed at some of the formatting but I can auto-fix that and re-push to get this through + released, I'm doing a bunch of PRs today so it fits in my flow
Will merge as soon as CI goes green
🏆 !
Description
Implement app check token change listener only for android ( as the sdk don't support for iOS )
onTokenChanged
function will be trigger with object containtoken, expireTimeMillis, appName
Checklist
Android
Test Plan