feat(app-distribution): Firebase V9 modular API #7307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #7307 +/- ##
============================================
- Coverage 53.97% 53.95% -0.02%
Complexity 736 736
============================================
Files 232 233 +1
Lines 11714 11726 +12
Branches 1875 1876 +1
============================================
+ Hits 6322 6326 +4
- Misses 5043 5051 +8
Partials 349 349 |
mikehardy
requested changes
Sep 4, 2023
| * @param {import('@react-native-firebase/app').ReactNativeFirebase.FirebaseApp | undefined} app | ||
| * @returns {import('.').AppDistribution} | ||
| */ | ||
| export function getAppDistribution(app) { |
There was a problem hiding this comment.
All of the APIs are showing up with codecov annotations as "untested".
- did you notice that?
- do you have any theories on that?
I've rebased the PR against current main and will re-push it which will re-trigger CI, maybe that will clear it. But I'm surprised that the e2e tests appear to be exercising it above yet the annotations of being untested are here with no explanation in the PR description 🤔
mikehardy
force-pushed
the
feat/app-distribution-modular
branch
from
0c5b227 to
598ff87
Compare
mikehardy
added
the
Workflow: Waiting for User Response
mikehardy
added
Workflow: Pending Merge
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
mikehardy
force-pushed
the
feat/app-distribution-modular
branch
from
d5e3924 to
2626703
Compare
mikehardy
previously approved these changes
Sep 4, 2023
mikehardy
force-pushed
the
feat/app-distribution-modular
branch
from
2626703 to
4e6268e
Compare
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issues
Release Summary
Checklist
AndroidiOSe2etests added or updated inpackages/\*\*/e2ejesttests added or updated inpackages/\*\*/__tests__Test Plan
Think
react-native-firebaseis great? Please consider supporting the project with any of the below:React Native FirebaseandInvertaseon Twitter