feat(in-app-messaging): Firebase V9 modular APIs #7306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
17 tasks
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #7306 +/- ##
============================================
- Coverage 53.97% 53.97% -0.00%
Complexity 736 736
============================================
Files 232 233 +1
Lines 11714 11720 +6
Branches 1875 1875
============================================
+ Hits 6322 6325 +3
- Misses 5043 5046 +3
Partials 349 349 |
russellwheatley
previously approved these changes
Sep 4, 2023
mikehardy
requested changes
Sep 4, 2023
| * @returns {boolean} | ||
| */ | ||
| export function isMessagesDisplaySuppressed(inAppMessaging) { | ||
| return inAppMessaging.isMessagesDisplaySuppressed; |
There was a problem hiding this comment.
Do you have any theories why the e2e tests are exercising the API but codecov is saying it is not exercised?
mikehardy
force-pushed
the
feat/in-app-messaging-modular
branch
from
534b5e9 to
ed9afa8
Compare
mikehardy
added
the
Workflow: Waiting for User Response
mikehardy
force-pushed
the
feat/in-app-messaging-modular
branch
from
ed9afa8 to
9e2bd1a
Compare
|
FirebaseInAppMessaging V9 modular APIs not exercised in CI Not sure exactly why coverage is showing up as not hitting these APIs when the tests seem to cover them |
mikehardy
removed
the
Workflow: Waiting for User Response
mikehardy
approved these changes
Sep 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issues
Release Summary
Checklist
AndroidiOSe2etests added or updated inpackages/\*\*/e2ejesttests added or updated inpackages/\*\*/__tests__Test Plan
Think
react-native-firebaseis great? Please consider supporting the project with any of the below:React Native FirebaseandInvertaseon Twitter