-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(auth, android): add forceRecaptchaFlowForTesting API #7148
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic! This is a great change, and the attention to detail in the PR is excellent - much appreciated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there were some completely trivial lint-type errors exposed by CI once I approved the CI runs, I just pushed a commit that cleans them all up, so it's ✨ clean, should go green now, will merge assuming yes / will fixup a touch more until it is green otherwise
The vercel deployment failure is not reproduced on other branches, going to ignore that here for the sake of merge and cleanup post-merge if it fails to deploy |
Co-authored-by: Mike Hardy <[email protected]>
Co-authored-by: Mike Hardy <[email protected]>
Description
Add support for the Android-only
forceRecaptchaFlowForTesting
method.Checklist
Android
iOS
e2e
tests added or updated inpackages/\*\*/e2e
jest
tests added or updated inpackages/\*\*/__tests__
Test Plan
Think
react-native-firebase
is great? Please consider supporting the project with any of the below:React Native Firebase
andInvertase
on Twitter