-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(database): Firebase V9 modular API #7136
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #7136 +/- ##
============================================
+ Coverage 53.97% 53.98% +0.01%
Complexity 736 736
============================================
Files 235 239 +4
Lines 11740 12001 +261
Branches 1876 1884 +8
============================================
+ Hits 6336 6477 +141
- Misses 5055 5176 +121
+ Partials 349 348 -1 |
0a2fabc
to
37a08d9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think there needs to be another nested directory in modular/api
, they can all go in modular/
4830308
to
9ad7629
Compare
…o ListenOptions.onlyOnce tests
1a270eb
to
9eef408
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - passes tests locally (even when rebased to main). Fantastic!
Is there a plan for when these changes will be released? I'm eagerly awaiting giving this a try. |
Hi there! They are all released as far as I know? I have been issuing releases as the modules were converted, and I believe they are all converted now. You can see the v9 API feature notes in the CHANGELOG here https://github.com/invertase/react-native-firebase/blob/main/CHANGELOG.md - this module (database) went out with v18.5.0 of react-native-firebase, 4 days ago just after your comment 😄 |
Thanks very much for your reply @mikehardy. I was so eager to try this I forgot that we're still blocked by the lack of Expo plugins for Database/Storage. It's not clear to me whether such plugins are community efforts or written by Invertase. I opened this discussion regarding the lack of clarity (or maybe I overlooked the explanation). |
Expo support is community driven |
Description
Related issues
Release Summary
Checklist
Android
iOS
e2e
tests added or updated inpackages/\*\*/e2e
jest
tests added or updated inpackages/\*\*/__tests__
Test Plan
Think
react-native-firebase
is great? Please consider supporting the project with any of the below:React Native Firebase
andInvertase
on Twitter