Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(database): Firebase V9 modular API #7136

Merged
merged 43 commits into from
Sep 19, 2023
Merged

feat(database): Firebase V9 modular API #7136

merged 43 commits into from
Sep 19, 2023

Conversation

exaby73
Copy link
Contributor

@exaby73 exaby73 commented May 25, 2023

Description

Related issues

Release Summary

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan


Think react-native-firebase is great? Please consider supporting the project with any of the below:

@vercel
Copy link

vercel bot commented May 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 19, 2023 11:15am
react-native-firebase-next ❌ Failed (Inspect) Sep 19, 2023 11:15am

@CLAassistant
Copy link

CLAassistant commented May 30, 2023

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented May 30, 2023

Codecov Report

Merging #7136 (9eef408) into main (5f6460a) will increase coverage by 0.01%.
Report is 2 commits behind head on main.
The diff coverage is 52.84%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #7136      +/-   ##
============================================
+ Coverage     53.97%   53.98%   +0.01%     
  Complexity      736      736              
============================================
  Files           235      239       +4     
  Lines         11740    12001     +261     
  Branches       1876     1884       +8     
============================================
+ Hits           6336     6477     +141     
- Misses         5055     5176     +121     
+ Partials        349      348       -1     

Copy link
Member

@russellwheatley russellwheatley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think there needs to be another nested directory in modular/api, they can all go in modular/

Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - passes tests locally (even when rebased to main). Fantastic!

@mikehardy mikehardy merged commit 21531f2 into main Sep 19, 2023
@mikehardy mikehardy deleted the feat/database-modular branch September 19, 2023 16:28
@Nantris
Copy link

Nantris commented Sep 22, 2023

Is there a plan for when these changes will be released? I'm eagerly awaiting giving this a try.

@mikehardy
Copy link
Collaborator

Hi there! They are all released as far as I know? I have been issuing releases as the modules were converted, and I believe they are all converted now. You can see the v9 API feature notes in the CHANGELOG here https://github.com/invertase/react-native-firebase/blob/main/CHANGELOG.md - this module (database) went out with v18.5.0 of react-native-firebase, 4 days ago just after your comment 😄

@Nantris
Copy link

Nantris commented Sep 27, 2023

Thanks very much for your reply @mikehardy. I was so eager to try this I forgot that we're still blocked by the lack of Expo plugins for Database/Storage. It's not clear to me whether such plugins are community efforts or written by Invertase. I opened this discussion regarding the lack of clarity (or maybe I overlooked the explanation).

@mikehardy
Copy link
Collaborator

Expo support is community driven

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Workflow: Needs Review Pending feedback or review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants