feat(storage): Firebase JS SDK v9 modular API #6958
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Codecov Report
@@ Coverage Diff @@
## main #6958 +/- ##
============================================
- Coverage 53.90% 53.66% -0.24%
Complexity 718 718
============================================
Files 228 229 +1
Lines 11303 11355 +52
Branches 1812 1815 +3
============================================
Hits 6092 6092
- Misses 4877 4926 +49
- Partials 334 337 +3 |
There was a problem hiding this comment.
This looks really good - I had two really minor thoughts for the changes implemented, trivial really but need a look
Main structural thought is that we've had one of these modular PRs go in with a delete of the non-modular tests, since the modular e2e includes the compatibility testing, that actually seems like a viable path forward, and reduces e2e time. We have also had a few go in like this where the e2e non-modular tests are effectively duplicated, with no delete of the original tests.
What do you prefer here? I lean towards a delete of the non-modular tests personally but it is a weakly held opinion.
docs/database/usage/index.md
Outdated
| @@ -50,7 +50,7 @@ import database from '@react-native-firebase/database'; | |||
| const reference = database().ref('/users/123'); | |||
| ``` | |||
|
|
|||
| NOTE: To get a reference to a database other than an 'us-central1' default database, you must pass the database URL. You can find your Realtime Database URL in the Realtime Database section of the Firebase console. | |||
| NOTE: To get a reference to a database other than a 'us-central1' default database, you must pass the database URL. You can find your Realtime Database URL in the Realtime Database section of the Firebase console. | |||
There was a problem hiding this comment.
Strange, I fixed this on main already, why is this showing up in a diff here? 🤔
There was a problem hiding this comment.
I updated it, I think a test was breaking because of incorrect grammar/spelling IIRC
There was a problem hiding this comment.
Also removed the duplicated non-modular e2e test files 👍
Description
See title.
Related issues
Release Summary
Checklist
AndroidiOSe2etests added or updated inpackages/\*\*/e2ejesttests added or updated inpackages/\*\*/__tests__Test Plan
Think
react-native-firebaseis great? Please consider supporting the project with any of the below:React Native FirebaseandInvertaseon Twitter