[🔥][🐛] [Android] App crashing on ConcurrentModificationException (ReactNativeFirebaseAuthModule) #6798
Comments
jianhui-chan
added
help: needs-triage
|
Hi there, I can look at this a bit later but please respond first and let me know if you still reproduce this on current versions, troubleshooting older versions is inefficient and not something we do in general |
|
Thanks for looking into this @mikehardy. We're currently only using |
|
+1 we are also seeing this behavior, we're unable to reproduce it locally but its flaring up on our crashlytics reports, running the latest versions. Identical behavior as above where a user has just opened the app, user is signed in and then immediately crashes with ConcurrentModificationException. |
|
+1 were also encountering this error in production. Same error stack. Unfortunately we are unable to replicate it locally but in production it crashes after the splash screen. Here's the error stack in crash reporting tool. |
|
+1 We are also encountering this error. @jianhui-chan were you able to mitigate the issue on your end? |
|
@isystem20 nope, I haven't found a solution for this issue |
|
We're now seeing this crash hit around 8% of our active users. |
|
No one has confirmed this happens on current stable versions. Someone please confirm this happens with current stable versions. |
|
Sorry this is happening for us on 16.5.0, RN 0.71.0. Will do another release today with 16.5.1 to see if this has an impact. |
|
@lwts thanks for confirming! 16.5.1 will not have an impact here, nothing in the area that would throw this stack changed. Always excited to have confirmation + stack traces but of course sorry this is happening for folks. I'll take a look |
mikehardy
added
Workflow: Needs Review
The auth provider data may apparently be modified while being iterated to send to listeners, resulting in a classic ConcurrentModificationException crash Using a shallow copy of the collection for iteration should be a functional equivalent, but without the unwanted "feature" of crashing Fixes #6798
|
The patch to fix this is I think fairly trivial. I've posted a PR for it here, and I would love if someone could try the patch set containing the fix (via patch-package) to make sure this fixes things for them. The patch set will be available here once the github actions workflow is done generating it: https://github.com/invertase/react-native-firebase/actions/runs/3975850361 |
|
Awesome thanks for the quick turnaround - implementing now and then we'll do a small scale roll out to check it fixes it. Should be able to get an idea within around 6 or so hours. EDIT: Looking good so far, has not reappeared. Will check again in the morning (8 or so hours) to confirm with newly updated users that nothing's popped up. |
|
Great - I took a break over the holidays but just did a release when I came back to make sure all the release machinery was 💯 and the queue was clear. So this will be a trivial patch release + easy to do as soon as you confirm. I could honestly do it now but as long as I have a motivated tester with the patch, might as well wait for the real results. Thanks for testing! |
|
Yeah it's still looking clear with a much larger roll out now so probs good to release. Thanks! |
|
Okay, I'll merge that and do a release - thanks again for testing+reporting Just so you are aware as maybe you can avoid extra work? - the release will be literally nothing but the current stable release (16.5.1) plus the patch-package you already integrated, and nothing else. It will be 16.5.2. Stated differently, if you have 16.5.1+those patches you already have 16.5.2 as it will be released so if you want to avoid re-releasing you might save some technically-duplicate effort. Obviously do whatever your release policies call for though :-). Cheers |
The auth provider data may apparently be modified while being iterated to send to listeners, resulting in a classic ConcurrentModificationException crash Using a shallow copy of the collection for iteration should be a functional equivalent, but without the unwanted "feature" of crashing Fixes #6798
mikehardy
removed
help: needs-triage
|
Does this patch work for 14.11.1 as well? |
|
@MishaFrenkman you'll have to try it and see, v14 is no longer supported. The code has not changed that much, I give it a 95% of applying cleanly, 5% of just needing a slight tweak in order to work. Shouldn't be too bad |
|
I wasn't able to do the patch as is on v14, but the origin bug report is referencing v14 as well. @jianhui-chan were you able to get the patch running or did you just upgrade to newer version? Thanks |
|
same issue for us, any update? |
Issue
Hello,
We've been seeing reports in Sentry that many of our Android users are experiencing crashes due to a
ConcurrentModificationExceptionhappening when theonIdTokenChangedlistener is being registered.We have not been able to replicate it locally so we're not exactly sure how this is happening as well.
Here is the stack trace for the error:
The behaviour we are observing (through Sentry) is as follows:
Here is how we are registering the listener:
In
componentDidMount, we are checking (via remote config) if firebase login is enabled and then registering the listener if it is enabled.Project Files
Javascript
Click To Expand
package.json:{ "name": "workmate", "version": "0.0.1", "private": true, "scripts": { "android": "react-native run-android --variant=devDebug --appIdSuffix=develop", "android-demo": "react-native run-android --variant=demoDebug --appIdSuffix=demo", "android-prod": "react-native run-android --variant=prodDebug", "ios": "react-native run-ios --scheme=WorkmateDev", "ios-demo": "react-native run-ios --scheme=WorkmateDemo", "ios-prod": "react-native run-ios --scheme=Workmate", "start": "react-native start", "test": "jest", "lint": "eslint .", "ts-migrate": "ts-migrate" }, "dependencies": { "@datadog/mobile-react-native": "^1.0.0-rc9", "@datadog/mobile-react-navigation": "^1.0.0-rc9", "@invertase/react-native-apple-authentication": "^2.1.5", "@react-native-async-storage/async-storage": "^1.17.7", "@react-native-clipboard/clipboard": "^1.9.0", "@react-native-community/checkbox": "^0.5.12", "@react-native-community/datetimepicker": "^6.1.4", "@react-native-community/masked-view": "^0.1.6", "@react-native-community/netinfo": "^5.8.0", "@react-native-community/push-notification-ios": "^1.10.1", "@react-native-firebase/analytics": "^14.11.0", "@react-native-firebase/app": "^14.11.0", "@react-native-firebase/auth": "^14.11.0", "@react-native-firebase/crashlytics": "^14.11.0", "@react-native-firebase/in-app-messaging": "^14.11.0", "@react-native-firebase/messaging": "^14.11.0", "@react-native-firebase/remote-config": "^14.11.0", "@react-native-google-signin/google-signin": "^7.0.1", "@react-native-picker/picker": "^2.4.2", "@react-navigation/bottom-tabs": "^5.11.11", "@react-navigation/material-top-tabs": "5.3.15", "@react-navigation/native": "^5.9.4", "@react-navigation/stack": "^5.14.5", "@segment/analytics-react-native": "^2.2.2", "@segment/sovran-react-native": "^0.2.8", "@sentry/cli": "^1.68.0", "@sentry/react-native": "^3.1.0", "@stream-io/flat-list-mvcp": "^0.10.1", "@twilio/conversations": "^2.1.0", "axios": "^0.21.1", "axios-auth-refresh": "^3.2.1", "axios-retry": "^3.1.9", "babel-runtime": "^6.26.0", "buffer": "^5.6.0", "cdigit": "^3.1.2", "eslint-plugin-react": "^7.18.3", "events": "^3.1.0", "formik": "^2.1.4", "graphql": "^16.6.0", "graphql-request": "^4.3.0", "graphql-tag": "^2.12.6", "humps": "^2.0.1", "i18next": "^19.3.2", "libphonenumber-js": "^1.9.42", "lodash": "^4.17.21", "moment": "^2.24.0", "numeral": "^2.0.6", "react": "17.0.2", "react-i18next": "^11.3.3", "react-native": "0.67.4", "react-native-autoheight-webview": "^1.6.1", "react-native-background-actions": "^2.6.2", "react-native-base64": "0.0.2", "react-native-bidirectional-infinite-scroll": "^0.3.3", "react-native-bootsplash": "^2.1.0", "react-native-branch": "^5.0.1", "react-native-camera": "^3.43.6", "react-native-code-push": "^7.0.4", "react-native-config": "^1.4.5", "react-native-confirmation-code-field": "^7.2.0", "react-native-country-picker-modal": "^2.0.0", "react-native-dash": "0.0.11", "react-native-datepicker": "^1.7.2", "react-native-device-info": "^8.7.1", "react-native-elements": "^1.2.7", "react-native-fast-image": "^8.5.11", "react-native-fbsdk-next": "7.0.1", "react-native-geolocation-service": "^5.2.0", "react-native-gesture-handler": "^1.10.3", "react-native-get-random-values": "^1.7.0", "react-native-html-to-pdf": "^0.12.0", "react-native-hyperlink": "0.0.19", "react-native-image-picker": "^3.3.2", "react-native-image-viewing": "^0.2.1", "react-native-keyboard-aware-scroll-view": "0.9.5", "react-native-lightbox": "^0.8.1", "react-native-linear-gradient": "^2.5.6", "react-native-localize": "^1.3.4", "react-native-maps": "^1.2.0", "react-native-mask-text": "^0.7.0", "react-native-mmkv-storage": "^0.7.6", "react-native-offline": "^5.8.0", "react-native-permissions": "^3.0.5", "react-native-picker-select": "^6.5.0", "react-native-print": "^0.10.0", "react-native-push-notification": "^8.1.1", "react-native-qrcode-svg": "^6.0.6", "react-native-reanimated": "^2.8.0", "react-native-safe-area-context": "^0.7.3", "react-native-scalable-image": "^1.0.0", "react-native-screens": "^2.0.0-beta.10", "react-native-send-intent": "^1.3.0", "react-native-signature-capture": "^0.4.12", "react-native-svg": "^12.1.1", "react-native-tab-view": "^2.16.0", "react-native-testing-library": "^1.13.2", "react-native-toast-notifications": "^3.1.1", "react-native-vector-icons": "^9.2.0", "react-native-webview": "^11.6.5", "react-query": "^3.34.19", "react-redux": "^7.2.0", "redux": "^4.0.5", "redux-logger": "^3.0.6", "redux-persist": "^6.0.0", "redux-thunk": "^2.3.0", "reselect": "^4.0.0", "rn-fetch-blob": "^0.13.0-beta.2", "rrule": "^2.6.4", "semver-compare": "^1.0.0", "twilio-chat": "^5.0.0", "use-count-up": "^2.3.1", "uuid": "^8.3.2", "yup": "^0.28.3" }, "devDependencies": { "@babel/core": "^7.12.9", "@babel/runtime": "^7.12.5", "@react-native-community/eslint-config": "^2.0.0", "@types/jest": "^27.4.0", "@types/lodash": "^4.14.180", "@types/react": "^17.0.39", "@types/react-native": "^0.66.16", "@types/react-native-html-to-pdf": "^0.8.1", "@types/react-redux": "^7.1.23", "@types/react-test-renderer": "^17.0.1", "@types/yup": "^0.29.13", "@typescript-eslint/eslint-plugin": "^5.12.1", "@typescript-eslint/parser": "^5.12.1", "babel-eslint": "^10.1.0", "babel-jest": "26.6.3", "babel-plugin-module-resolver": "^4.1.0", "eslint": "7.14.0", "eslint-config-prettier": "6.10.0", "eslint-import-resolver-node": "^0.3.3", "eslint-import-resolver-typescript": "^2.5.0", "eslint-plugin-import": "^2.25.4", "eslint-plugin-prettier": "3.1.2", "fast-csv": "^4.3.6", "jest": "^26.6.3", "jest-extended": "^0.11.5", "metro-react-native-babel-preset": "^0.66.2", "prettier": "1.19.1", "react-dom": "^17.0.2", "react-native-clean-project": "^3.3.0", "react-native-codegen": "^0.0.7", "react-test-renderer": "17.0.2", "ts-migrate": "^0.1.28", "typescript": "^4.5.5" }, "jest": { "preset": "react-native", "moduleFileExtensions": [ "ts", "tsx", "js", "jsx", "json", "node" ], "setupFilesAfterEnv": [ "jest-extended", "./jest.setup.js" ], "transformIgnorePatterns": [ "node_modules/(?!(@?(react-native|invertase)(-[^/]+)?)/)" ], "moduleNameMapper": { "^@/(.*)$": "<rootDir>/$1" } } }firebase.jsonfor react-native-firebase v6:{}iOS
Click To Expand
ios/Podfile:AppDelegate.m:Android
Click To Expand
Have you converted to AndroidX?
android/gradle.settingsjetifier=truefor Android compatibility?jetifierfor react-native compatibility?android/build.gradle:android/app/build.gradle:android/settings.gradle:MainApplication.java:AndroidManifest.xml:Environment
Click To Expand
As mentioned, we've not been able to replicate this locally but this is a list of devices that have been experiencing this issue:
react-native-firebaseversion you're using that has this issue:^14.11.0Firebasemodule(s) you're using that has the issue:@react-native-firebase/authTypeScript?Y&^4.5.5React Native FirebaseandInvertaseon Twitter for updates on the library.The text was updated successfully, but these errors were encountered: