fix(database,typescript): transaction update types

[alexkuttig]

Description

There was an error in the type definition of transactions of the realtime database. When using transactions with non-object values like number or boolean, tsc threw an error (TS2345: Argument of type '(data: object) => number' is not assignable to parameter of type '(currentData: object) => object'.   Type 'number' is not assignable to type 'object'.). When comparing the type definition of react-native-firebase with the one of the official firebase documentation here: https://firebase.google.com/docs/reference/js/v8/firebase.database.Reference#transaction you can see the difference. I changed the type definitions accordingly.

Related issues

Release Summary

fixed typedefinition for realtime database transactions

Checklist

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • Yes
• My change supports the following platforms;
  • Android
  • iOS
• My change includes tests;
  • e2e tests added or updated in packages/\*\*/e2e
  • jest tests added or updated in packages/\*\*/__tests__
• I have updated TypeScript types that are affected by my change.
• This is a breaking change;
  • Yes
  • No

Test Plan

You can test the new type definition by creating a realtime database transaction with a non object type (like the example in the comment).

const userRef = firebase.database().ref('users/ada/profileViews);

userRef.transaction((currentViews) => {
  if (currentViews === null) return 1;
  return currentViews + 1;
});

With the old definition, this will throw an error. With the new definition, this will work.

Think react-native-firebase is great? Please consider supporting the project with any of the below:

• 👉 Star this repo on GitHub ⭐️
• 👉 Follow React Native Firebase and Invertase on Twitter

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated
react-native-firebase	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Dec 14, 2022 at 2:45PM (UTC)

1 Ignored Deployment

Name	Status	Preview	Comments	Updated
react-native-firebase-next	⬜️ Ignored (Inspect)			Dec 14, 2022 at 2:45PM (UTC)

[codecov]

Codecov Report

Merging #6782 (32cadd3) into main (e3bd896) will decrease coverage by 18.63%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##               main    #6782       +/-   ##
=============================================
- Coverage     72.22%   53.59%   -18.62%     
- Complexity        0      690      +690     
=============================================
  Files           119      218       +99     
  Lines          4855    10895     +6040     
  Branches       1083     1746      +663     
=============================================
+ Hits           3506     5838     +2332     
- Misses         1266     4739     +3473     
- Partials         83      318      +235     

[github-actions]

Hello 👋, this PR has been opened for more than 2 months with no activity on it.

If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing!

You have 15 days until this gets closed automatically

[mikehardy]

This still needs a review! I'm behind, apologies

[mikehardy]

Sorry for the delay on this, it looks correct, thank you!