-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(analytics): expose native automatic screenview reporting toggle #5948
Conversation
Automatic screenview tracking can now be disabled/enabled via firebase.json through "google_analytics_automatic_screen_reporting_enabled" property.
This pull request is being automatically deployed with Vercel (learn more). react-native-firebase – ./🔍 Inspect: https://vercel.com/invertase/react-native-firebase/58kAn6gkyBEnRj2N8iLZPczmn2Wm react-native-firebase-next – ./website_modular🔍 Inspect: https://vercel.com/invertase/react-native-firebase-next/7U5QYtRtgMBQwgR6F5w1M6BjjGGo [Deployment for 29a8600 canceled] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks perfect first time! Thank you. I've got two other fixes just merged, hopefully CI goes green on this and I'll release it today
Codecov Report
@@ Coverage Diff @@
## main #5948 +/- ##
=============================================
- Coverage 53.04% 25.45% -27.59%
=============================================
Files 208 97 -111
Lines 10171 4245 -5926
Branches 1618 1033 -585
=============================================
- Hits 5394 1080 -4314
+ Misses 4523 2571 -1952
- Partials 254 594 +340 |
Nothing at all wrong with the implementation - I just shepherded it through the trivial lint line-spacing / spellchecking crud 😄 --> merged! 🚀 |
Thanks a lot! |
I'm not sure (how to do all this )
…On Sat, Dec 18, 2021, 2:17 PM se09deluca ***@***.***> wrote:
Thanks a lot!
It has been my first contribution, I’m not expert on this. Next time I’ll
surely give more attention!
🙏🏻
|
Description
See related issue comment
Automatic screenview tracking can now be disabled/enabled via firebase.json throught "google_analytics_automatic_screen_reporting_enabled" property.
Automatic screenview reporting (enabled by default) previously could not be disabled trought firebase.json configuration file, but only adding the meta tag in AndroidManifest.xml or Info.plist key (the native way).
This commit includes the needed adds in build.gradle and ios_config.sh to make these config exposed to the react native project.
Release Summary
Includes google_analytics_automatic_screen_reporting_enabled in firebase.json properties
Checklist
Android
iOS