Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New firebase-ads / google-mobile-ads-sdk incompatible with v11 #5150

Closed
mikehardy opened this issue Apr 10, 2021 · 6 comments
Closed

New firebase-ads / google-mobile-ads-sdk incompatible with v11 #5150

mikehardy opened this issue Apr 10, 2021 · 6 comments
Labels
impact: crash Behaviour causing app to crash. platform: android plugin: admob Google AdMob

Comments

@mikehardy
Copy link
Collaborator

If you are using @react-native-firebase/admob, you must not update to firebase-android-sdk v27.x.x with react-native-firebase v11.x.x

Issue

The upcoming 27.0.0 firebase-android-sdk will contain an updated firebase-ads reference (v20 there, previous v19) https://firebase.google.com/support/release-notes/android

That references an updated v20 of google-mobile-ads-sdk - https://developers.google.com/admob/android/migration

react-native-firebase v11.x.x is not compatible with this breaking change (yet), specifically:


@mikehardy
Copy link
Collaborator Author

I have a PR up that will pin the dependency directly in our module (#5189) and I'll issue a v12.0.0 release here that will forward port to the new library soon

@mikehardy
Copy link
Collaborator Author

When the forward port is done and v27 is the BoM we should also be able to remove the browser dependency workaround #4490 - 56c653e

@mikehardy mikehardy unpinned this issue May 18, 2021
@mikehardy
Copy link
Collaborator Author

With apologies Admob no longer present in v12 as it was removed in upstream SDKs so there are no APIs to wrap any longer - please stay with v11.5 until migration to another project (either from this same code in a new repo - planned, or a different project)

@stale
Copy link

stale bot commented Jun 26, 2021

Hello 👋, to help manage issues we automatically close stale issues.
This issue has been automatically marked as stale because it has not had activity for quite some time. Has this issue been fixed, or does it still require the community's attention?

This issue will be closed in 15 days if no further activity occurs.
Thank you for your contributions.

@stale stale bot added the Type: Stale Issue has become stale - automatically added by Stale bot label Jun 26, 2021
@birdofpreyru
Copy link

To prevent the bot from closing this issue, I'll wonder: any news on AdMob support by RN-Firebase, or a well-tested advice on an easy migration from [email protected] to a different library? Also, the last time I checked, I understood that Ads were gone from Firebase and this library for good, but checking-in now, and finding this ticket, it reads like a new ads implementation is in-place in Firebase, and potentially will be supported by RN-Firebase library? Can somebody clarify what is going on, and what is the recommended course of action for folks who still depend on [email protected]?

@stale stale bot removed the Type: Stale Issue has become stale - automatically added by Stale bot label Jul 5, 2021
@mikehardy
Copy link
Collaborator Author

Hey there! Good catch waking the stale bot up. Status (or, announcements) will be here - #5329 as that has the most traffic.
I don't have updates, but

  • admob is no longer a part of firebase at all, throughout firebase ecosystem - that's an upstream change. It's done, we're just following
  • the plan is: lift-and-shift admob code from @react-native-firebase/admob v11.5 to the new-not-public-yet react-native-admob that will be under Invertase namespace (I think), then open it up to the community for forward ports etc with similar level of quality / docs / support that react-native-firebase has enjoyed over the years

The holdup is mostly on invertase / my end as I was just personally unavailable for nearly a month and it's been quite a struggle to get back to the leading edge of all my work efforts and really move them forward - apologies for that

This comment really sums up the state and we have a discussion open so I'm going to close the issue but hopefully the explanation make it clear what the thinking / plan is

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact: crash Behaviour causing app to crash. platform: android plugin: admob Google AdMob
Projects
None yet
Development

No branches or pull requests

2 participants