Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(auth): verifyBeforeUpdateEmail API #3862

Merged
merged 9 commits into from
Jul 10, 2020
Merged

feat(auth): verifyBeforeUpdateEmail API #3862

merged 9 commits into from
Jul 10, 2020

Conversation

russellwheatley
Copy link
Member

@russellwheatley russellwheatley commented Jun 30, 2020 •
edited by Salakar
Loading

Description

Release Summary

  • auth module verifyBeforeUpdateEmail API.
  • Added unhappy test paths for verifyBeforeUpdateEmail & sendEmailVerification. Would be better if we could just create one user and delete after they've all ran as it is very expensive time wise.

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan

Think react-native-firebase is great? Please consider supporting the project with any of the below:

@Ehesp
Copy link
Member

Ehesp commented Jul 1, 2020

write e2e tests? Not sure how to confirm by clicking link sent to email.

Just make sure it successfully resolves - and whilst manual testing check it does actually work (sending to your email). Not much else we can do there.

Salakar
Salakar requested changes Jul 6, 2020
View reviewed changes
Copy link
Contributor

@Salakar Salakar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some minor feedback, sorry 🙈

Not sure how to confirm by clicking link sent to email.

I wouldn't worry about this to be honest - verifying the method is called correctly without errors I think is sufficient.

Salakar
Salakar approved these changes Jul 10, 2020
View reviewed changes
Copy link
Contributor

@Salakar Salakar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@russellwheatley russellwheatley marked this pull request as ready for review July 10, 2020 13:07
@russellwheatley russellwheatley merged commit aaff624 into master Jul 10, 2020
@russellwheatley russellwheatley deleted the @russell/verifyBeforeUpdateEmail branch July 10, 2020 13:08
@Salakar Salakar mentioned this pull request Jul 14, 2020
Closed
9 tasks
androidIsForVivek pushed a commit to androidIsForVivek/react-native-firebase that referenced this pull request Sep 15, 2021
@russellwheatley
feat(auth): verifyBeforeUpdateEmail API (invertase#3862)
910b1de 
* feat(auth): 1st commit verifyBeforeUpdateEmail

* feat(auth): verifyBeforeUpdateEmail updates

* tests(auth): more coverage

* chore(ios): update podfile.lock

* tests(auth): update verifyBeforeUpdateEmail tests

* tests(auth): verifyBeforeUpdateEmail updates
[publish]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Salakar Salakar Salakar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@russellwheatley @Ehesp @Salakar