Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(auth): use correct code on network exception #3655

Merged
merged 1 commit into from
May 15, 2020
Merged

Conversation

Salakar
Copy link
Contributor

@Salakar Salakar commented May 15, 2020

Description

Error code on Android should be network-request-failed when FirebaseNetworkException is throw.

Related issues

Fixes #3654.

Release Summary

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Think react-native-firebase is great? Please consider supporting the project with any of the below:

@Salakar Salakar marked this pull request as ready for review May 15, 2020 12:34
@Salakar Salakar merged commit 8bcf5c9 into master May 15, 2020
@Salakar Salakar deleted the @salakar/issue3654 branch May 15, 2020 12:35
stefkampen pushed a commit to stefkampen/react-native-firebase that referenced this pull request Jun 6, 2020
androidIsForVivek pushed a commit to androidIsForVivek/react-native-firebase that referenced this pull request Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent error code for getIdToken iOS vs Android, when device offline
1 participant