feat(app): add Play Services available utilities #3601
Conversation
There was a problem hiding this comment.
Looks like exactly how I handle this in my app but with custom stuff, will be nice to have this in firebase!
Side comment - out of the 8 files changed, 5 were changed in non-semantic / formatting only ways, is that expected behavior? Makes the diff really big and a bit scattered when functionally it's not so large. Not a big deal, just something I noticed
…act-native-firebase into @russell/play-service-utils
@mikehardy It should've probably been in its own PR to be honest, but I ran the |
Sorted on master, so this should be clean now. In terms of review - I noticed @russellwheatley that the documentation has been done in the messaging package for some reason? Shouldn't be in there |
|
@Salakar I have no idea what that is doing in the messaging docs, prolly should've had a bigger slurp of coffee before that commit 😓 . |
…act-native-firebase into @russell/play-service-utils
…act-native-firebase into @russell/play-service-utils
Salakar
changed the title
Co-authored-by: Mike Diarmid <[email protected]> [publish]
The correct fix would re-use invertase built-in gradle variable machinery I just hacked in the "standard" 'getExt' function from most react-native-packages This is a workaround for: invertase/react-native-firebase#3943 Related to invertase/react-native-firebase#3601
Co-authored-by: Mike Diarmid <[email protected]> [publish]
fixes this issue: https://invertase.canny.io/react-native-firebase/p/playservicesavailability.
Replaces: #3240
NOTES
firebase.utils().makePlayServicesAvailable()orfirebase.utils().resolutionForPlayServices()as I'm not sure it's possible. Will update if there is a way.