Skip to content

Commit

Permalink
fix(functions): properly pass the custom URL or region to constructor (
Browse files Browse the repository at this point in the history
  • Loading branch information
Lyokone authored Jul 10, 2024
1 parent 272efe5 commit ffaac4f
Showing 1 changed file with 12 additions and 3 deletions.
15 changes: 12 additions & 3 deletions packages/functions/lib/modular/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,10 @@ export function getFunctions(app, regionOrCustomDomain) {
* @param {number} port The emulator port. (ex: 5001)
*/
export function connectFunctionsEmulator(functionsInstance, host, port) {
return firebase.app(functionsInstance.app.name).functions().useEmulator(host, port);
return firebase
.app(functionsInstance.app.name)
.functions(functionsInstance._customUrlOrRegion)
.useEmulator(host, port);
}

/**
Expand All @@ -56,7 +59,10 @@ export function connectFunctionsEmulator(functionsInstance, host, port) {
* @returns {HttpsCallable}
*/
export function httpsCallable(functionsInstance, name, options) {
return firebase.app(functionsInstance.app.name).functions().httpsCallable(name, options);
return firebase
.app(functionsInstance.app.name)
.functions(functionsInstance._customUrlOrRegion)
.httpsCallable(name, options);
}

/**
Expand All @@ -67,5 +73,8 @@ export function httpsCallable(functionsInstance, name, options) {
* @returns {HttpsCallable}
*/
export function httpsCallableFromUrl(functionsInstance, url, options) {
return firebase.app(functionsInstance.app.name).functions().httpsCallableFromUrl(url, options);
return firebase
.app(functionsInstance.app.name)
.functions(functionsInstance._customUrlOrRegion)
.httpsCallableFromUrl(url, options);
}

0 comments on commit ffaac4f

Please sign in to comment.