fix(auth): allow emulator hostnames to contain hyphens (#6141)

invertase · Mar 23, 2022 · 98eb1ce · 98eb1ce · vercel · Mar 23, 2022
1 parent ca50d6e
commit 98eb1ce
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/packages/auth/__tests__/auth.test.ts b/packages/auth/__tests__/auth.test.ts
@@ -42,6 +42,11 @@ describe('Auth', function () {
       const bar = auth().useEmulator('http://127.0.0.1:9099');
       expect(bar).toEqual(['10.0.2.2', 9099]);
     });
+
+    it('useEmulator allows hyphens in the hostname', function () {
+      const result = auth().useEmulator('http://my-host:9099');
+      expect(result).toEqual(['my-host', 9099]);
+    });
   });
 
   describe('tenantId', function () {

diff --git a/packages/auth/lib/index.js b/packages/auth/lib/index.js
@@ -381,7 +381,7 @@ class FirebaseAuthModule extends FirebaseModule {
     }
 
     // Native calls take the host and port split out
-    const hostPortRegex = /^http:\/\/([\w\d.]+):(\d+)$/;
+    const hostPortRegex = /^http:\/\/([\w\d-.]+):(\d+)$/;
     const urlMatches = _url.match(hostPortRegex);
     if (!urlMatches) {
       throw new Error('firebase.auth().useEmulator() unable to parse host and port from URL');