fix: use same deprecation message everywhere, correct tests for new m…

…essage
invertase · Feb 8, 2025 · 684081b · 684081b
1 parent cbda9e5
commit 684081b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/packages/app/lib/common/index.js b/packages/app/lib/common/index.js
@@ -362,10 +362,8 @@ export function warnIfNotModularCall(args, replacementMethodName = '') {
       return;
     }
   }
-  let message =
-    'This v8 method is deprecated and will be removed in the next major release ' +
-    'as part of move to match Firebase Web modular v9 SDK API.';
 
+  let message = v8deprecationMessage;
   if (replacementMethodName.length > 0) {
     message += ` Please use \`${replacementMethodName}\` instead.`;
   }

diff --git a/packages/crashlytics/e2e/crashlytics.e2e.js b/packages/crashlytics/e2e/crashlytics.e2e.js
@@ -91,14 +91,13 @@ describe('crashlytics()', function () {
         // eslint-disable-next-line no-console
         console.warn = msg => {
           // we console.warn for deprecated API, can be removed when we move to v9
-          if (!msg.includes('v8 method is deprecated')) {
+          if (!msg.includes('method is deprecated')) {
             msg.should.containEql('expects an instance of Error');
             logged = true;
             // eslint-disable-next-line no-console
             console.warn = orig;
           }
         };
-
         firebase.crashlytics().recordError(1337);
         should.equal(logged, true);
       });
@@ -265,7 +264,7 @@ describe('crashlytics()', function () {
         // eslint-disable-next-line no-console
         console.warn = msg => {
           // we console.warn for deprecated API, can be removed when we move to v9
-          if (!msg.includes('v8 method is deprecated')) {
+          if (!msg.includes('method is deprecated')) {
             msg.should.containEql('expects an instance of Error');
             logged = true;
             // eslint-disable-next-line no-console