From 1ae74816e4d70b129d831e4adf14794d4c69c372 Mon Sep 17 00:00:00 2001 From: Michael Nahkies Date: Fri, 12 Apr 2024 03:25:21 +0100 Subject: [PATCH] fix(auth): deprecate MultiFactorUser.enrolledFactor should be plural `enrolledFactors` (#7652) * fix!: enrolledFactors rather than enrolledFactor the typescript definitions specify it as `enrolledFactors` reflecting that it is an array, but the javascript was actually setting it as `enrolledFactor` at runtime. ref: - typings: https://github.com/invertase/react-native-firebase/blob/main/packages/auth/lib/index.d.ts#L568 - android: https://github.com/invertase/react-native-firebase/blob/main/packages/auth/android/src/main/java/io/invertase/firebase/auth/ReactNativeFirebaseAuthModule.java#L2476 - ios: https://github.com/invertase/react-native-firebase/blob/main/packages/auth/ios/RNFBAuth/RNFBAuthModule.m#L1681 - web sdk: https://github.com/firebase/firebase-js-sdk/blob/master/packages/auth/src/mfa/mfa_user.ts#L34 --- packages/auth/lib/multiFactor.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/packages/auth/lib/multiFactor.js b/packages/auth/lib/multiFactor.js index 889f01b617..e1bc0e4f37 100644 --- a/packages/auth/lib/multiFactor.js +++ b/packages/auth/lib/multiFactor.js @@ -14,6 +14,8 @@ export class MultiFactorUser { user = auth.currentUser; } this._user = user; + this.enrolledFactors = user.multiFactor.enrolledFactors; + // @deprecated kept for backwards compatibility, please use enrolledFactors this.enrolledFactor = user.multiFactor.enrolledFactors; }