Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If changed, use latest PR title in release notes and changelog #1081

Closed
smoia opened this issue Mar 27, 2020 · 7 comments · Fixed by #1082
Closed

If changed, use latest PR title in release notes and changelog #1081

smoia opened this issue Mar 27, 2020 · 7 comments · Fixed by #1082
Labels
bug Something isn't working released This issue/pull request has been released.

Comments

@smoia
Copy link

smoia commented Mar 27, 2020

Is your feature request related to a problem? Please describe.
I'm not sure whether this is a bug or a feature.
Implementing Auto in a repository (issue physiopy/phys2bids#181 ), we realised that the PR title used to create the changelog and the release notes doesn't match with the current title of our PRs.
This is because we changed the titles recently, to make them more human readable, while the title used in the changelog seems to be the one with which the PR was open.

Describe the solution you'd like
It would be great if Auto considered the updated PR title, if it changed since the PR was opened.

Additional context
See physiopy/phys2bids#181

@smoia smoia added the enhancement New feature or request label Mar 27, 2020
@hipstersmoothie hipstersmoothie added bug Something isn't working and removed enhancement New feature or request labels Mar 27, 2020
@hipstersmoothie
Copy link
Collaborator

I'll take a look at this. It should use the updated title, but you would have to generate the changelog again.

I've definitely changed titles before though.

@smoia
Copy link
Author

smoia commented Mar 27, 2020

Thank you @hipstersmoothie .
I was playing with auto while updating the labels of our PRs, and I see that also the labels are not respected (see our chagelog again).

@hipstersmoothie
Copy link
Collaborator

Not that running from within a PR can give you odd changelog results. Looking into this now. It's cool to see a python project using auto!

@smoia
Copy link
Author

smoia commented Mar 27, 2020

Yes, we're excited too!
I preferred auto to other packages because I strongly support the use of labels rather than angular commit conventions and similar!

Once our PR is ready and everything works fine, you can add us as an example of Travis CI configuration and python-based-auto-adopting project, if you want!

@smoia
Copy link
Author

smoia commented Mar 27, 2020

Also, I should specify that the changelog that you see in physiopy/phys2bids#181 was obtained by running auto locally on my computer.

@hipstersmoothie
Copy link
Collaborator

recreated locally. should have a fix in today

@adierkens
Copy link
Collaborator

🚀 Issue was released in v9.21.1 🚀

@adierkens adierkens added the released This issue/pull request has been released. label Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants