diff --git a/agent/agent_common/pom.xml b/agent/agent_common/pom.xml index d21cc3e77..3a384b606 100644 --- a/agent/agent_common/pom.xml +++ b/agent/agent_common/pom.xml @@ -15,18 +15,19 @@ - ${project.groupId} api ${project.version} - + + commons-fileupload + commons-fileupload + org.jdom jdom2 - jakarta.xml.ws jakarta.xml.ws-api diff --git a/agent/agent_common/src/main/java/com/intuit/tank/http/TankHttpUtil.java b/agent/agent_common/src/main/java/com/intuit/tank/http/TankHttpUtil.java index f548c4f9e..e9c00b131 100644 --- a/agent/agent_common/src/main/java/com/intuit/tank/http/TankHttpUtil.java +++ b/agent/agent_common/src/main/java/com/intuit/tank/http/TankHttpUtil.java @@ -12,6 +12,7 @@ import java.util.Map; import org.apache.commons.codec.binary.Base64; +import org.apache.commons.fileupload.MultipartStream; import org.apache.commons.lang3.StringUtils; import org.apache.logging.log4j.LogManager; import org.apache.logging.log4j.Logger; @@ -19,7 +20,6 @@ import com.intuit.tank.http.binary.BinaryResponse; import com.intuit.tank.http.json.JsonResponse; import com.intuit.tank.http.xml.XMLResponse; -import org.apache.tomcat.util.http.fileupload.MultipartStream; import static java.util.stream.Collectors.joining; diff --git a/api/src/main/java/com/intuit/tank/storage/S3FileStorage.java b/api/src/main/java/com/intuit/tank/storage/S3FileStorage.java index e87b83d08..0f4223ea4 100644 --- a/api/src/main/java/com/intuit/tank/storage/S3FileStorage.java +++ b/api/src/main/java/com/intuit/tank/storage/S3FileStorage.java @@ -7,6 +7,7 @@ import java.util.zip.GZIPInputStream; import org.apache.commons.io.FilenameUtils; +import org.apache.commons.io.IOUtils; import org.apache.commons.lang3.StringUtils; import org.apache.http.client.utils.URIBuilder; import org.apache.logging.log4j.LogManager; @@ -15,7 +16,6 @@ import com.intuit.tank.vm.settings.CloudCredentials; import com.intuit.tank.vm.settings.CloudProvider; import com.intuit.tank.vm.settings.TankConfig; -import org.apache.tomcat.util.http.fileupload.IOUtils; import software.amazon.awssdk.auth.credentials.AwsBasicCredentials; import software.amazon.awssdk.auth.credentials.AwsCredentials; import software.amazon.awssdk.auth.credentials.StaticCredentialsProvider; diff --git a/pom.xml b/pom.xml index 6af79178e..63af99ae9 100644 --- a/pom.xml +++ b/pom.xml @@ -306,28 +306,6 @@ weld-servlet-core test - - - org.apache.tomcat.embed - tomcat-embed-core - test - - - - org.apache.tomcat - tomcat-catalina - test - - - org.apache.tomcat - tomcat-coyote - provided - - - org.apache.tomcat - tomcat-jasper - provided - @@ -543,6 +521,11 @@ json-rpc 1.0 + + commons-fileupload + commons-fileupload + 1.5 + commons-io commons-io diff --git a/rest-mvc/impl/pom.xml b/rest-mvc/impl/pom.xml index 9e2e3c57b..d1d1efff6 100644 --- a/rest-mvc/impl/pom.xml +++ b/rest-mvc/impl/pom.xml @@ -47,6 +47,11 @@ tank-script-processor ${project.version} + + org.apache.tomcat + tomcat-coyote + provided + diff --git a/rest-mvc/impl/src/main/java/com/intuit/tank/rest/mvc/rest/util/ScriptServiceUtil.java b/rest-mvc/impl/src/main/java/com/intuit/tank/rest/mvc/rest/util/ScriptServiceUtil.java index aff29efb3..ad9d73aa1 100644 --- a/rest-mvc/impl/src/main/java/com/intuit/tank/rest/mvc/rest/util/ScriptServiceUtil.java +++ b/rest-mvc/impl/src/main/java/com/intuit/tank/rest/mvc/rest/util/ScriptServiceUtil.java @@ -14,9 +14,9 @@ import com.intuit.tank.script.models.*; import com.intuit.tank.script.RequestDataPhase; +import org.apache.commons.io.IOUtils; import org.apache.logging.log4j.LogManager; import org.apache.logging.log4j.Logger; -import org.apache.tomcat.util.http.fileupload.IOUtils; import org.xml.sax.InputSource; import org.xml.sax.SAXException; @@ -329,7 +329,7 @@ public static ScriptTO parseXMLtoScriptTO(InputStream inputStream) { JAXBContext ctx = JAXBContext.newInstance(ScriptTO.class.getPackage().getName()); return (ScriptTO) ctx.createUnmarshaller().unmarshal(xmlSource); } catch (ParserConfigurationException | JAXBException | SAXException e) { - LOG.error("Error unmarshalling script: " + e.getMessage() , e); + LOG.error("Error unmarshalling script: {}", e.getMessage(), e); throw new WebApplicationException(e, Response.Status.INTERNAL_SERVER_ERROR); } finally { IOUtils.closeQuietly(inputStream); diff --git a/script_processor/src/main/java/com/intuit/tank/script/util/ScriptServiceUtil.java b/script_processor/src/main/java/com/intuit/tank/script/util/ScriptServiceUtil.java index eaf817a29..3a3aa00a1 100644 --- a/script_processor/src/main/java/com/intuit/tank/script/util/ScriptServiceUtil.java +++ b/script_processor/src/main/java/com/intuit/tank/script/util/ScriptServiceUtil.java @@ -26,9 +26,9 @@ import com.intuit.tank.project.Script; import com.intuit.tank.project.ScriptStep; import com.intuit.tank.script.RequestDataPhase; +import org.apache.commons.io.IOUtils; import org.apache.logging.log4j.LogManager; import org.apache.logging.log4j.Logger; -import org.apache.tomcat.util.http.fileupload.IOUtils; import org.xml.sax.InputSource; import org.xml.sax.SAXException; @@ -43,7 +43,6 @@ import javax.xml.transform.Source; import javax.xml.transform.sax.SAXSource; import java.io.InputStream; -import java.io.UnsupportedEncodingException; import java.net.URLDecoder; import java.net.URLEncoder; import java.nio.charset.StandardCharsets; @@ -366,7 +365,7 @@ public static ScriptTO parseXMLtoScriptTO(InputStream inputStream) { JAXBContext ctx = JAXBContext.newInstance(ScriptTO.class.getPackage().getName()); return (ScriptTO) ctx.createUnmarshaller().unmarshal(xmlSource); } catch (ParserConfigurationException | JAXBException | SAXException e) { - LOG.error("Error unmarshalling script: " + e.getMessage() , e); + LOG.error("Error unmarshalling script: {}", e.getMessage(), e); throw new WebApplicationException(e, Response.Status.INTERNAL_SERVER_ERROR); } finally { IOUtils.closeQuietly(inputStream); diff --git a/web/web_support/pom.xml b/web/web_support/pom.xml index 9803dadae..3edbe754a 100644 --- a/web/web_support/pom.xml +++ b/web/web_support/pom.xml @@ -187,7 +187,26 @@ runtime - + + org.apache.tomcat.embed + tomcat-embed-core + test + + + org.apache.tomcat + tomcat-catalina + test + + + org.apache.tomcat + tomcat-coyote + provided + + + org.apache.tomcat + tomcat-jasper + provided + \ No newline at end of file