Remove usage of nixWrapped. #4866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbgi
requested review from
a team,
deepfire,
mgmeier and
fmaste
as code owners
it was introduced for adding flake flags by default and also as a work around for nix flake show/check: NixOS/nix#4265 But the added complexity is not worth it, given it breaks other workflows with nix run (since the wrapper script does not use `exec`). Also nowadays everyone (should) have flake activated by default in the nix config.
angerman
approved these changes
Feb 10, 2023
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Feb 17, 2023
4866: Remove usage of nixWrapped. r=jbgi a=jbgi it was introduced for adding flake flags by default and also as a work around for nix flake show/check: NixOS/nix#4265 But the added complexity is not worth it, given it breaks other workflows with nix run (since the wrapper script does not use `exec`). Also nowadays everyone (should) have flake activated by default in the nix config. Co-authored-by: Jean-Baptiste Giraudeau <[email protected]>
|
Timed out. |
|
bors retry |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it was introduced for adding flake flags by default and also as a work around for nix flake show/check: NixOS/nix#4265 But the added complexity is not worth it, given it breaks other workflows with nix run (since the wrapper script does not use
exec).Also nowadays everyone (should) have flake activated by default in the nix config.