Remove unnecessary validation of Data #4344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelpj
requested review from
dcoutts,
Jimbo4350,
erikd,
newhoggy and
JaredCorduan
as code owners
|
This PR is stale because it has been open 45 days with no activity. |
|
This is still relevant. |
newhoggy
requested review from
LudvikGalois and
CarlosLopezDeLara
as code owners
newhoggy
force-pushed
the
mpj/remove-data-valiation
branch
from
bc666ca to
105b6a4
Compare
newhoggy
approved these changes
Mar 16, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
newhoggy
force-pushed
the
mpj/remove-data-valiation
branch
from
105b6a4 to
8ebeb40
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
newhoggy
force-pushed
the
mpj/remove-data-valiation
branch
from
8ebeb40 to
42687a8
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Close to the release of Alonzo, we improved the format of `Data` to allow arbitrary-size integers and bytestrings by requiring them to be encoded in CBOR using indefinite-length bytestrings. This means that the client-side validation performed by the API was never necessary, and can be removed.
newhoggy
force-pushed
the
mpj/remove-data-valiation
branch
from
42687a8 to
2efdd2c
Compare
mkoura
added a commit
to IntersectMBO/cardano-node-tests
that referenced
this pull request
Mar 17, 2023
mkoura
added a commit
to IntersectMBO/cardano-node-tests
that referenced
this pull request
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4218, but from a branch in the upstream repo.