Append change instead of prepending it #4343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LudvikGalois
requested review from
dcoutts,
Jimbo4350,
erikd,
newhoggy and
JaredCorduan
as code owners
LudvikGalois
force-pushed
the
ludvikgalois/append-change
branch
from
a6ce063 to
552e439
Compare
It's desirable for a client to be able to predict the index of outputs. As such we append change to the end so that the index of other outputs doesn't changed based on whether there's change or not. Resolves #3725
LudvikGalois
force-pushed
the
ludvikgalois/append-change
branch
from
552e439 to
706dca7
Compare
newhoggy
approved these changes
Aug 16, 2022
|
bors r+ |
|
Build succeeded: |
mkoura
added a commit
to mkoura/cardano-node-tests
that referenced
this pull request
Aug 18, 2022
mkoura
added a commit
to IntersectMBO/cardano-node-tests
that referenced
this pull request
Aug 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's desirable for a client to be able to predict the index of outputs.
As such we append change to the end so that the index of other outputs
doesn't changed based on whether there's change or not.
Resolves #3725