Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registrant API: nameserver and registrar info is missing #991

Closed
vohmar opened this issue Sep 21, 2018 · 3 comments · Fixed by #997
Closed

Registrant API: nameserver and registrar info is missing #991

vohmar opened this issue Sep 21, 2018 · 3 comments · Fixed by #997
Assignees

Comments

@vohmar
Copy link
Contributor

vohmar commented Sep 21, 2018

domain info query returns only registrar id and does not return nameserver info. There is no other option to query this info so domain details' query should return this info with other domain details. Registrar object id is not needed in the details in this case as there is no way to use it.

https://github.com/internetee/registry/blob/registry-849/doc/registrant-api/v1/domain.md

@vohmar
Copy link
Contributor Author

vohmar commented Oct 3, 2018

please add ip addresses of nameservers as well

@vohmar
Copy link
Contributor Author

vohmar commented Oct 3, 2018

and registrar url

@maciej-szlosarczyk
Copy link
Contributor

@vohmar Please try again with #997

Nameservers should be returned as an array:

// ...
  "nameservers": [
    {
      "hostname": "ns1.bestnames.test",
      "ipv4": ["173.245.58.41"],
      "ipv6": ["2400:cb00:2049:1::adf5:3a33"]
    },
    {
      "hostname": "ns1.bestnames.test",
      "ipv4": ["173.245.58.51"],
      "ipv6": ["2400:cb00:2049:1::adf5:3b29"]
    },
  ],
// ...

Registrar now is an Object, not a String:

  "registrar": {
     "name": "Best Names",
     "website": "example.com"
  },

I also removed an abandoned database column, domains.status. It is empty in production database and never referenced in code either. Given that it was created in June 2014, I assume that's quite some legacy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants